Use changesets for releases, use Node 20 #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
ericglau
changed the title
CoveMB
approved these changes
May 9, 2025
ernestognw
approved these changes
May 9, 2025
tirumerla
approved these changes
May 9, 2025
| title: Prepare Release | ||
| commit: Prepare Release | ||
| version: npm run version | ||
| commitMode: github-api |
There was a problem hiding this comment.
Is this specifically for signing commits or any other advantages over cli?
There was a problem hiding this comment.
Yes, according to the Changesets changelog,
When used with "github-api" value all tags and commits will be attributed to the user whose GITHUB_TOKEN is used, and also signed using GitHub's internal GPG key.
| commitMode: github-api | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
For future reference making comment to enable config provenance when pushing
There was a problem hiding this comment.
Adding link to related comment for tracking: OpenZeppelin/contracts-wizard#528 (comment)
tirumerla
reviewed
May 9, 2025
| contents: write | ||
| pull-requests: write | ||
| runs-on: ubuntu-latest | ||
| environment: publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses changesets for versioning and publishing.
Updates build environment to Node.js v20.
Equivalent to OpenZeppelin/contracts-wizard#528