-
Notifications
You must be signed in to change notification settings - Fork 12.1k
Update OZ solhint custom rules [WIP] #5794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update OZ solhint custom rules [WIP] #5794
Conversation
|
For reference, there is already this PR that deals with linter rules: #5497 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I would like to add another rule to verify that Interfaces can only import other interfaces
AFAIK, this is already something solidity enforces. We don't need the linter to check taht if the compiler rejects it anyway.
Edit: that is true of "inheritance", importing is a different thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How efficient/explicit is /^_/.test(node.name)
compared to node.name.startsWith('_')
interface-names
custom rule which is now covered by solhint's already includedinterface-starts-with-i
interface-only-external-functions
rule.Note that 2, 3, and 4 require breaking changes that can be potential candidates for 6.0
Ideally I would like to add another rule to verify that Interfaces can only import other interfaces