Skip to content

Formal verification of Account (7702+7579) #5785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Formal verification of Account (7702+7579) #5785

wants to merge 8 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jul 6, 2025

No description provided.

@Amxx Amxx requested a review from a team as a code owner July 6, 2025 16:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6f2e783

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security Socket Security
Copy link

socket-security bot commented Jul 6, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedpypi/​certora-cli@​4.13.1 ⏵ 7.31.089 -410010010070 -30

View full report

Amxx
Amxx commented Jul 8, 2025
View reviewed changes
certora/diff/account_extensions_draft-AccountERC7579.sol.patch
Comment on lines +7 to +11
- address handler = _fallbackHandler(msg.sig);
- require(handler != address(0), ERC7579MissingFallbackHandler(msg.sig));
+ bytes4 selector = bytes4(msg.data[0:4]);
+ address handler = _fallbackHandler(selector);
+ require(handler != address(0), ERC7579MissingFallbackHandler(selector));
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary for the prover to understand that the selector being looked for matches the data being passed the the fallback handler. Don't ask me how many hours I wasted figuring that out !

Amxx
Amxx commented Jul 8, 2025
View reviewed changes
certora/specs/Account.spec
}
}

rule delegatecallOpcodeRule(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule doesn't work. Some function can trigger CALL that HAVOC the ghosts ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Account Abstraction formal-verification Enable FV run in a PR. ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Amxx