You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes issue #5607 by updating the misleading comment in the EIP712 contract that incorrectly refers to "immutable values" in the upgradeable version.
As suggested by @Amxx, I've replaced the comment with:
NOTE: The upgradeable version of this contract does not use an immutable cache and recomputes the domain separator each time {_domainSeparatorV4} is called. That is cheaper than accessing a cached version in cold storage.
This change is made in the upgradeable.patch file which is used during the transpilation process to generate the upgradeable contract variants, as recommended by @ernestognw.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Fix misleading comment in EIP712Upgradeable by updating the comment in the transpilation patch file. The previous comment incorrectly referred to immutable values that don't exist in the upgradeable version.
The patch file has also been cleaned of trailing whitespace.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
naevern
force-pushed
the
fix/eip712-upgradeable-comment
branch
from
This PR fixes issue #5607 by updating the misleading comment in the EIP712 contract that incorrectly refers to "immutable values" in the upgradeable version.
As suggested by @Amxx, I've replaced the comment with:
This change is made in the upgradeable.patch file which is used during the transpilation process to generate the upgradeable contract variants, as recommended by @ernestognw.
Fixes #5607
PR Checklist
npx changeset add)