Skip to content

fix: number_to_digits catalan placeholder #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix: number_to_digits catalan placeholder #9

merged 1 commit into from
Nov 13, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 13, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced support for the Catalan language in number parsing functionalities.
    • Introduced functions to convert written numbers to digits for Catalan (numbers_to_digits_ca), Spanish (numbers_to_digits_es), and Portuguese (numbers_to_digits_pt).
  • Documentation

    • Updated README to reflect the support status of Catalan, Spanish, and Portuguese languages for the numbers_to_digits functionality.
  • Chores

    • Removed the obsolete status from the package metadata in setup.py.

@github-actions github-actions bot added the fix label Nov 13, 2024
Copy link
Contributor

coderabbitai bot commented Nov 13, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces updates to the ovos_number_parser module, enhancing its support for the Catalan, Spanish, and Portuguese languages in the number parsing functionality. The README.md reflects changes in language support status, while new functions are added to handle number parsing for each of these languages. The setup.py file is also modified to remove the obsolete status of the package, indicating a more active development status.

Changes

File Change Summary
README.md Updated language support status for Catalan, Spanish, and Portuguese in numbers_to_digits.
ovos_number_parser/init.py Added import for numbers_to_digits_ca and integrated Catalan support in various functions.
ovos_number_parser/numbers_ca.py Added numbers_to_digits_ca function for converting Catalan numbers to digits.
ovos_number_parser/numbers_es.py Added numbers_to_digits_es function for converting Spanish numbers to digits.
ovos_number_parser/numbers_pt.py Added numbers_to_digits_pt function for converting Portuguese numbers to digits and defined tokenize.
setup.py Removed obsoletes parameter from setup() function, indicating active status of the package.

Possibly related PRs

  • feat: numbers_to_digits #1: The changes in the README.md file regarding the support status of languages for the numbers_to_digits functionality are directly related to the updates made in the same file in PR feat: numbers_to_digits #1, which also modifies the support status for Catalan, Spanish, and Portuguese languages.

Poem

In the land of numbers, we hop and play,
With Catalan, Spanish, and Portuguese on display.
From words to digits, we make the switch,
Parsing with joy, without a hitch!
So come, dear friends, let's count and cheer,
For every language, we hold so dear! 🐰✨

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 721e381 and 92aca48.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl merged commit de68a7e into dev Nov 13, 2024
1 check passed
@github-actions github-actions bot added fix and removed fix labels Nov 13, 2024
@github-actions github-actions bot added fix and removed fix labels Nov 13, 2024
@JarbasAl JarbasAl deleted the fix_ca branch February 27, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant