-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/7883 add count plotters #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KueblerJelle
wants to merge
11
commits into
main
Choose a base branch
from
feature/7883-add-count-plotters
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the counting process from the exporting and make it reusable
added counts image wrapping a PIL image, and some metadata: name, timestamp, width and height an abstract CountsPlotter handles obtaining Count object from a TrafficCounting, counting specification and actual plotting of the data is delegated to subclasses a CountsPlotter can produce multiple CountsImages per Count being plotted (e.g. one plot per flow) added abstract MatplotlibCountsPlotter, applying a predefined style (MatplotlibPlotStyler) to a matplotlib figure/axes, subclasses can plot the data on the provided Axes object MultipleCountsPlotters wraps multiple CountsPlotters, delegates plot call and collects all CountsImages added example FlowByModeCountPlotter which currently only prints the count as dict to the console
this list of CountsImages can be used to store/update the computed count plots and notify observers added usecase CountPlotsUpdater which observes width and height of track view state as well as the event repository and trigger the provided plotter when notified the newly created CountImages are set in the track view state, replacing the previous images
add missing get_counting_specification to MultipleCountsPlotters pass list of plotters in constructor Add data class FigurePlotter to wrap name and plotting-lambda for matplotlib plotting Updated MatplotlibCountPlotStyler: styling of track plotting could unfortunately not be reused styler can receive a list of FigurePlotters, the styler sets up figure and axes, applies the plotter and then styles the axes for each FigurePlotter Implemented Flow/Classification based plotters apply plotters for testing in base application/add observers for testing in gui_application
apply CountPlotSaver in base_application, register plot saver as observer at count plot list in TrackViewState
…iew model trigger count plot update after create events undo changes for testing in TrafficCounting disabling create_events removed update count plots use case as observer from event repo in gui application
renamed class names containing "...Counts..." to "...Count..."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OP#7883