Skip to content

[IMP] spp_openid_vci: close windown when clicking confirm button #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

reichie020212
Copy link
Member

Why is this change needed?

Issue Card modal is not closing after clicking confirm button

How was the change implemented?

added close="1" parameter to the button.

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Install spp_openid_vci_individual
  • Go to Registry -> Individual
  • enter 1 record.
  • click the Issue Card smart button
  • click confirm button
  • after the generation of the ID card, the modal should be automatically closed.

Related links

Copy link

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (bb28b61) to head (d9435af).
Report is 4 commits behind head on 17.0.

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #796      +/-   ##
==========================================
- Coverage   75.69%   75.67%   -0.03%     
==========================================
  Files         764      764              
  Lines       20218    20218              
  Branches     2501     2501              
==========================================
- Hits        15304    15299       -5     
- Misses       4380     4382       +2     
- Partials      534      537       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants