Skip to content

Modify the spp_change_request module to support SP-MIS and Farmer Registry CR type modules #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

gonzalesedwin1123
Copy link
Member

Why is this change needed?

A new spp_change_request_base module is created in PR: #777 to support any change request implementations. This PR will modify the existing spp_change_request to support only the SP-MIS and Farmer Registry change request implementations.

How was the change implemented?

The spp_change_request module was modified and will depend on the new parent module spp_change_request_base. SP-MIS and Farmer Registry specific change request requirements will be maintained in this module.

New unit tests

Unit tests executed by the author

How to test manually

Related links

Enhancement to Change Request module

@gonzalesedwin1123 gonzalesedwin1123 self-assigned this Apr 15, 2025
@gonzalesedwin1123 gonzalesedwin1123 linked an issue Apr 15, 2025 that may be closed by this pull request
Copy link

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.70%. Comparing base (108bdbc) to head (8c696fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             17.0     #791      +/-   ##
==========================================
+ Coverage   75.68%   75.70%   +0.01%     
==========================================
  Files         764      764              
  Lines       20218    20218              
  Branches     2501     2501              
==========================================
+ Hits        15303    15306       +3     
+ Misses       4381     4378       -3     
  Partials      534      534              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to Change Request module
1 participant