Introduce print-as-raster as printer/job attribute #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
requested changes
Jun 2, 2025
There was a problem hiding this comment.
I like the idea of this but would prefer to use a different attribute/option name, e.g., "print-as-raster", to keep the naming consistent with other print mode options/attributes.
Also, the job-state-reasons keyword needs to stay as "cups-retry-as-raster" since we save this information (when a job had to be retried) for accounting/diagnostic purposes.
zdohnal
changed the title
zdohnal
force-pushed
the
force-raster
branch
2 times, most recently
from
1583a91 to
bec5409
Compare
|
@michaelrsweet thank you for the review! I have applied the feedback + taken the liberty to update man pages to include the option. Feel free to check once you have the moment. |
michaelrsweet
requested changes
Jun 9, 2025
Some printers do not take kindly newer PDF versions which results in omitting font characters in the printout. Such jobs print fine as a raster, however retrying as raster depends on benevolence of the printer firmware what it counts as an unrecoverable printing error. In the past, we preferred raster over PDF in cups-filters, causing other issues like with finishings, or solutions like generating PCLm PPD were mentioned, however it would require a way how to define for which models it should be used, and take of such database. Thus introducing `print-as-raster` job attribute, which makes the job to be printed as raster, and `print-as-raster-default` printer attributes, which makes any job coming into the printer object to be printed as raster. Internally it uses similar mechanism as raster retry, which was adjusted to match both use cases now.
|
Added, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDITED - see the old version in history.
Some printers do not take kindly newer PDF versions which results in
omitting font characters in the printout. Such jobs print fine as a
raster, however retrying as raster depends on benevolence of the printer
firmware what it counts as an unrecoverable printing error.
In the past, we preferred raster over PDF in cups-filters, causing other
issues like with finishings, or solutions like generating PCLm PPD were
mentioned, however it would require a way how to define for which models
it should be used, and take of such database.
Thus introducing
print-as-rasterjob attribute, which makes the jobto be printed as raster, and
print-as-raster-defaultprinter attributes,which makes any job coming into the printer object to be printed as raster.
Internally it uses similar mechanism as raster retry, which was adjusted
to match both use cases now.