Map: Removing map parts can cause out-of-bounds access #2428
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the last but one map part was removed, setCurrentPartIndex() did an out-of-bounds read access to the parts vector, due to switching to the last map part before removing the last but one part. Closes OpenOrienteeringGH-2427 (Removing last but one map part causes out-of-bounds access).
dl3sdo
commented
Oct 17, 2025
| // First switch to another part when removing the current part | ||
| setCurrentPartIndex((index == parts.size() - 1) ? (parts.size() - 2) : (index + 1)); | ||
| // First switch to another part when removing the current part, this will also clear any object selection | ||
| setCurrentPartIndex((index == parts.size() - 1) ? (index - 1) : (index + 1)); |
There was a problem hiding this comment.
Although index - 1 is equivalent to parts.size() - 2 I prefer it due to readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the last but one map part was removed, setCurrentPartIndex() did an out-of-bounds read access to the parts vector, due to switching to the last map part before removing the last but one part.
Closes GH-2427 (Removing last but one map part causes out-of-bounds access).