OgrFileImport: Import rotation angle of point objects (DXF) #2362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DXF driver of GDAL/OGR does not (yet) import the rotation angle of point objects (code 50). However, the driver stores all codes which are not handled by the driver itself in a generic field 'RawCodeValues' if the driver is configured with DXF_INCLUDE_RAW_CODE_VALUES being set to TRUE. Parse the 'RawCodeValues' field for the occurrence of a code 50 property and set the rotation angle accordingly. Closes OpenOrienteeringGH-2133 (Point object angle/rotation is lost during DXF import).
|
I propose to merge #2136 first and then evaluate this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DXF driver of GDAL/OGR does not (yet) import the rotation angle of point objects (code 50).
However, the driver stores all codes which are not handled by the driver itself in a generic field 'RawCodeValues' if the driver is configured with DXF_INCLUDE_RAW_CODE_VALUES being set to TRUE.
Parse the 'RawCodeValues' field for the occurrence of a code 50 property and set the rotation angle accordingly.
Closes GH-2133 (Point object angle/rotation is lost during DXF import).