SymbolReplacementDialog: Show active symbol replacement strategy #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add checkmark to show the active symbol replacement criteria (either name or number) in the 'Symbol mapping' drop-down menu.
|
Proposed change: ShowSymbolSetRule.mp4 |
|
... but it is only true until the users makes manual adjustments. (It is an action, not a state.) |
|
Actually it's an action but the markers also show the actual state when setting up the dialog and after triggering one of the two actions. Considering manual adjustments is of course straightforward. As the benefit of this PR is limited I leave it to you whether to use or refuse the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkmark to show the active symbol replacement strategy (either name or number) in the 'Symbol mapping' drop-down menu.
Refer to #2359 for the context of this PR.