-
Notifications
You must be signed in to change notification settings - Fork 121
Feature: Remove object tags #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@dg0yt: I'm not sure whether using a 'trash' button in the tag editor widget is the right way for invoking the tag removal dialog. OTOH I did not find a suitable location in the menu and I don't want to overload Mapper's menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want at least to move TagRemoveDialog
to a different filename and to add it to the code check wrapper.
I'm not yet happy with the UI, but I can't propose actual improvements at the moment.
Add dialog to remove object tags from selected objects that match a configurable pattern. Allow to create an undo step. Closes OpenOrienteeringGH-2354 (Remove objects tags).
Show more information in main dialog. Remove details from final confirmation popup.
@dg0yt: Since I placed the action in the Map menu now should I move the .cpp and .h files to the gui/map folder (where e.g. map information and map notes are...but not the georeferencing dialog)? |
There is currently a decoupling of the tags and objects being found (and shown) by the Find button and the actual deletion by the Remove button: If the user either changes the comparison operator or the key value and does not click Find again, the object tags that would be removed are not the ones actually being shown but those based on the current search parameters. Proposal: Only remove those object tags that are the result of the search initiated by Find (and disable the Remove button if either the comparison operator or the key value field have changed). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Add dialog to remove object tags from selected objects that match a configurable pattern.
Allow to create an undo step.
Closes GH-2354 (Remove objects tags).