Skip to content

Conversation

dl3sdo
Copy link
Member

@dl3sdo dl3sdo commented Mar 29, 2025

Add dialog to remove object tags from selected objects that match a configurable pattern.
Allow to create an undo step.

Closes GH-2354 (Remove objects tags).

@dl3sdo dl3sdo requested a review from dg0yt April 1, 2025 08:01
@dl3sdo
Copy link
Member Author

dl3sdo commented Apr 1, 2025

@dg0yt: I'm not sure whether using a 'trash' button in the tag editor widget is the right way for invoking the tag removal dialog. OTOH I did not find a suitable location in the menu and I don't want to overload Mapper's menu.

Copy link
Member

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want at least to move TagRemoveDialog to a different filename and to add it to the code check wrapper.

I'm not yet happy with the UI, but I can't propose actual improvements at the moment.

dl3sdo added 2 commits May 20, 2025 22:39
Add dialog to remove object tags from selected objects that match
a configurable pattern.
Allow to create an undo step.

Closes OpenOrienteeringGH-2354 (Remove objects tags).
Show more information in main dialog. Remove details from
final confirmation popup.
@dl3sdo
Copy link
Member Author

dl3sdo commented May 20, 2025

@dg0yt: Since I placed the action in the Map menu now should I move the .cpp and .h files to the gui/map folder (where e.g. map information and map notes are...but not the georeferencing dialog)?

@dl3sdo
Copy link
Member Author

dl3sdo commented May 21, 2025

There is currently a decoupling of the tags and objects being found (and shown) by the Find button and the actual deletion by the Remove button: If the user either changes the comparison operator or the key value and does not click Find again, the object tags that would be removed are not the ones actually being shown but those based on the current search parameters.

Proposal: Only remove those object tags that are the result of the search initiated by Find (and disable the Remove button if either the comparison operator or the key value field have changed).

@dl3sdo dl3sdo marked this pull request as draft May 21, 2025 11:02
@dl3sdo dl3sdo marked this pull request as ready for review May 25, 2025 20:38
@dl3sdo
Copy link
Member Author

dl3sdo commented May 27, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dl3sdo dl3sdo requested a review from dg0yt May 31, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Remove object tags

2 participants