Rename internal variables and methods to start with _
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make workflow runs with linter errors fail faster.
For some reason, I only get this warning when running in github actions.
The type hints were misleadingly saying int, when in fact subprocess.run accepts float timeouts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #254
I wasn't sure about these, so I left them alone:
isParameterChangeable()be part of the public API?setTempDirectory()be part of the public API?setCommandLineOptions()be part of the public API? (I.e. should it be allowed to set extra options after the object is constructed? We already have acommandLineOptionsarg in the constructor.)To minimize future merge conflicts, and for me to be able to take advantage of
pre-commitwhile making these changes, this PR is based on #289.