Media Gallery behavior when duplicating a product: Keep/Skip product images #5083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copy the images or not. added a configuration option “Skip Images on Duplicate” and a small prompt on Duplicate when the source product has images.
github-actions
bot
added
Component: Catalog
# Conflicts: # app/code/core/Mage/Catalog/Model/Product.php
|
sreichel
reviewed
Nov 9, 2025
Comment on lines
+656
to
+662
| /** | ||
| * @return int | ||
| */ | ||
| public function skipProductImageOnDuplicate() | ||
| { | ||
| return Mage::getStoreConfigAsInt(self::XML_NODE_SKIP_IMAGE_ON_DUPLICATE_ACTION); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @return int | |
| */ | |
| public function skipProductImageOnDuplicate() | |
| { | |
| return Mage::getStoreConfigAsInt(self::XML_NODE_SKIP_IMAGE_ON_DUPLICATE_ACTION); | |
| } | |
| public function skipProductImageOnDuplicate(): int | |
| { | |
| return Mage::getStoreConfigAsInt(self::XML_NODE_SKIP_IMAGE_ON_DUPLICATE_ACTION); | |
| } |
sreichel
reviewed
Nov 9, 2025
| * @return string | ||
| */ | ||
| public function getDuplicateUrl() | ||
| public function getDuplicateUrl($skipImages = false) |
Contributor
There was a problem hiding this comment.
Suggested change
| public function getDuplicateUrl($skipImages = false) | |
| public function getDuplicateUrl(bool $skipImages = false) |
Contributor
There was a problem hiding this comment.
Maybe add a new method getDuplicateSkipUrl()?
sreichel
reviewed
Nov 9, 2025
Comment on lines
+31
to
+36
| /** | ||
| * Used when duplicating product | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $_skipImagesOnDuplicate = false; |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * Used when duplicating product | |
| * | |
| * @var string | |
| */ | |
| protected $_skipImagesOnDuplicate = false; | |
| /** | |
| * Used when duplicating product | |
| */ | |
| protected bool $skipImagesOnDuplicate = false; |
sreichel
reviewed
Nov 9, 2025
Comment on lines
+747
to
+752
| /** | ||
| * @param bool $newProductSkipImages | ||
| * @return $this | ||
| */ | ||
| public function setSkipImagesOnDuplicate(bool $newProductSkipImages){ | ||
| $this->_skipImagesOnDuplicate = $newProductSkipImages; |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @param bool $newProductSkipImages | |
| * @return $this | |
| */ | |
| public function setSkipImagesOnDuplicate(bool $newProductSkipImages){ | |
| $this->_skipImagesOnDuplicate = $newProductSkipImages; | |
| /** | |
| * @return $this | |
| */ | |
| public function setSkipImagesOnDuplicate(bool $newProductSkipImages) | |
| { | |
| $this->skipImagesOnDuplicate = $newProductSkipImages; |
sreichel
reviewed
Nov 9, 2025
Comment on lines
+756
to
+761
| /** | ||
| * @return bool|string | ||
| */ | ||
| public function getSkipImagesOnDuplicate(){ | ||
| return $this->_skipImagesOnDuplicate; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| /** | |
| * @return bool|string | |
| */ | |
| public function getSkipImagesOnDuplicate(){ | |
| return $this->_skipImagesOnDuplicate; | |
| } | |
| public function getSkipImagesOnDuplicate(): bool | |
| { | |
| return $this->skipImagesOnDuplicate; | |
| } |
sreichel
reviewed
Nov 9, 2025
Comment on lines
+762
to
+763
|
|
||
|
|
sreichel
reviewed
Nov 9, 2025
Comment on lines
+1370
to
+1374
| if($newProduct->getSkipImagesOnDuplicate() == null && $this->_getImageHelper()->skipProductImageOnDuplicate() === -1){ | ||
| $newProduct->setSkipImagesOnDuplicate(false); | ||
| }else{ | ||
| $newProduct->setSkipImagesOnDuplicate((bool) $this->_getImageHelper()->skipProductImageOnDuplicate()); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if($newProduct->getSkipImagesOnDuplicate() == null && $this->_getImageHelper()->skipProductImageOnDuplicate() === -1){ | |
| $newProduct->setSkipImagesOnDuplicate(false); | |
| }else{ | |
| $newProduct->setSkipImagesOnDuplicate((bool) $this->_getImageHelper()->skipProductImageOnDuplicate()); | |
| } | |
| if (is_null($newProduct->getSkipImagesOnDuplicate()) && $this->_getImageHelper()->skipProductImageOnDuplicate() === -1) { # todo: use constant | |
| $newProduct->setSkipImagesOnDuplicate(false); | |
| } else { | |
| $newProduct->setSkipImagesOnDuplicate($this->_getImageHelper()->skipProductImageOnDuplicate()); | |
| } |
Contributor
|
Much thanks. Please run phpcs-fixer and phpstan. Some errors should be fixed via suggestions. I'd add constants for options, of Please revert changes for trailing spaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm splitting up the work in 3 PRs after @addison74's comment in
Parts:
image,small_image,thumbnailattributesThis PR: Keep/Skip product images
System > Configuration > Catalog > Product Image > Skip Images on Duplicate(always ask, skip, keep)Questions or comments
Need help in adding tests