PhpStan: fix wrong params null given

[sreichel]

... docblocks.

[Copilot]

Pull Request Overview

This PR focuses on code quality improvements by standardizing variable naming conventions, improving docblock annotations, and simplifying code expressions. The changes enhance maintainability and align with PHPStan static analysis requirements.

Key changes:

• Renamed loop iteration variables from generic names like $i, $k, $v, $e to more descriptive names ($index, $key, $value, $exception)
• Improved PHPDoc annotations with accurate return types and @throws declarations
• Simplified ternary expressions using the ?: operator
• Fixed string interpolation syntax consistency
• Corrected PHPStan baseline issues

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
lib/Varien/Simplexml/Element.php	Renamed $newLine to $eol for clarity
lib/Varien/Db/Adapter/Pdo/Mysql.php	Standardized variable names, improved docblocks, simplified ternary operators, fixed string interpolation
lib/Varien/Db/Adapter/Interface.php	Added null type to docblock for optional parameter
app/code/core/Mage/Weee/Helper/Data.php	Simplified ternary operator, improved docblocks
app/code/core/Mage/Tax/Model/Resource/Calculation.php	Renamed loop indices, improved docblocks, fixed string interpolation
app/code/core/Mage/Tax/Model/Calculation.php	Renamed variables, improved docblocks, fixed null handling
app/code/core/Mage/Sales/Model/Order/Creditmemo/Total/Shipping.php	Changed null to empty array for currency format method
app/code/core/Mage/Oauth/controllers/Adminhtml/Oauth/ConsumerController.php	Renamed $id to $consumerId, $e to specific exception names
app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php	Changed default limit from null to 0, improved docblocks, simplified assignment
app/code/core/Mage/Core/Model/Resource/Db/Abstract.php	Renamed generic loop variables, improved docblocks
app/code/core/Mage/ConfigurableSwatches/Model/System/Config/Source/Catalog/Product/Configattribute/Select.php	Fixed array_unshift usage to avoid modifying reference
app/code/core/Mage/ConfigurableSwatches/Model/System/Config/Source/Catalog/Product/Configattribute.php	Updated property docblock type
app/code/core/Mage/Checkout/Block/Cart/Item/Renderer.php	Added null type to docblocks
app/code/core/Mage/Catalog/Block/Product/List/Toolbar.php	Improved docblocks with accurate types and exception annotations
.phpstan.dist.baseline.neon	Removed resolved PHPStan errors from baseline

[github-actions]

Test Results

880 tests  +1   869 ✅ +1   15s ⏱️ ±0s
195 suites +1    11 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit c6afdeb. ± Comparison against base commit 2220264.

♻️ This comment has been updated with latest results.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
7 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sreichel]

Safe.