Skip to content

Conversation

@vernard
Copy link
Contributor

@vernard vernard commented Oct 16, 2025

Description (*)

During checkout (or cart page) when asking UPS for rates, there are times where I get a "Too Many Requests" error. I've replicated that API call through Postman.

When that happens, their XML response doesn't have a space in it. That includes the space in <?xml version="1.0"?>. They sent it as <?xmlversion="1.0"?> which throws an error.
image

image

Manual testing scenarios (*)

  1. Do a checkout and get UPS rates.
    Sorry, this error doesn't happen in our live production. Maybe it only happens in my country (Philippines)?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Usa Relates to Mage_Usa label Oct 16, 2025
@sonarqubecloud
Copy link

@Hanmac
Copy link
Contributor

Hanmac commented Oct 16, 2025

I think this is something that should be reported to UPS itself too, if able?

@vernard
Copy link
Contributor Author

vernard commented Oct 16, 2025

I couldn't find any information about this issue on the internet. Perhaps it's not as common.

@Hanmac
Copy link
Contributor

Hanmac commented Oct 17, 2025

There is a Contact Form on the UPS page: https://www.ups.com/upsemail/input
but that only works if you got a UPS Account

Might report that problem there? (with link to this issue?)

i'm going to merge this MR anyway

@Hanmac Hanmac merged commit 3595a18 into OpenMage:main Oct 17, 2025
21 checks passed
@vernard vernard deleted the ups-too-many-requests-fix branch October 17, 2025 07:35
@vernard
Copy link
Contributor Author

vernard commented Oct 17, 2025

Yay my first PR. Glad to be a legit contributor.

Thanks

@sreichel sreichel added the bug label Oct 17, 2025
@vernard
Copy link
Contributor Author

vernard commented Nov 6, 2025

@sreichel Can I be added in contributors on the homepage? I was hoping to be next to @lc-excell coz we're teammates.

@sreichel
Copy link
Contributor

sreichel commented Nov 6, 2025

Sorry, missed your comment.

@all-contributors add vernad code

@allcontributors
Copy link
Contributor

@sreichel

I've put up a pull request to add @vernad! 🎉

@vernard
Copy link
Contributor Author

vernard commented Nov 6, 2025

@sreichel typo on my name. It's vernard, not vernad

@sreichel
Copy link
Contributor

sreichel commented Nov 6, 2025

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Component: Usa Relates to Mage_Usa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants