-
-
Notifications
You must be signed in to change notification settings - Fork 452
Fix invalid XML when UPS returns "Too Many Requests" error #5011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
I think this is something that should be reported to UPS itself too, if able? |
|
I couldn't find any information about this issue on the internet. Perhaps it's not as common. |
|
There is a Contact Form on the UPS page: https://www.ups.com/upsemail/input Might report that problem there? (with link to this issue?) i'm going to merge this MR anyway |
|
Yay my first PR. Glad to be a legit contributor. Thanks |
|
@sreichel Can I be added in contributors on the homepage? I was hoping to be next to @lc-excell coz we're teammates. |
|
Sorry, missed your comment. @all-contributors add vernad code |
|
I've put up a pull request to add @vernad! 🎉 |
|
@sreichel typo on my name. It's vernard, not vernad |
|
Fixed. |



Description (*)
During checkout (or cart page) when asking UPS for rates, there are times where I get a "Too Many Requests" error. I've replicated that API call through Postman.
When that happens, their XML response doesn't have a space in it. That includes the space in

<?xml version="1.0"?>. They sent it as<?xmlversion="1.0"?>which throws an error.Manual testing scenarios (*)
Sorry, this error doesn't happen in our live production. Maybe it only happens in my country (Philippines)?
Contribution checklist (*)