rector: CombineIfRector
#4880
Draft
rector: CombineIfRector
#4880
+1,246
−1,771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sreichel
commented
Jul 8, 2025
sreichel
commented
- see https://getrector.com/rule-detail/combine-if-rector
github-actions
bot
added
Component: PayPal
github-actions
bot
added
Component: Review
|
kiatng
reviewed
Jul 8, 2025
| ) { | ||
| return true; | ||
| } | ||
| if (($attribute = $this->getAttribute()) && (!$attribute->isScopeGlobal() && $this->getDataObject() && $this->getDataObject()->getId() && $this->getDataObject()->getStoreId())) { |
There was a problem hiding this comment.
This is a long one. Also, it can simplify to return $condition
There was a problem hiding this comment.
I agree. This doesnt enhance readability.
pquerner
reviewed
Jul 8, 2025
| @@ -160,19 +160,17 @@ public function canReturnToStock() | |||
| */ | |||
| public function canReturnItemsToStock() | |||
| { | |||
| if (is_null($this->_canReturnToStock)) { | |||
There was a problem hiding this comment.
Oh boy.. setting something in a if and also in a setter.
pquerner
reviewed
Jul 8, 2025
| 'onclick' => Mage::helper('core/js')->getSetLocationJs($this->getCreditMemoUrl()), | ||
| ]); | ||
| } | ||
| if ($this->_isAllowedAction('creditmemo') && $this->getInvoice()->getOrder()->canCreditmemo() && ($orderPayment->canRefundPartialPerInvoice() && $this->getInvoice()->canRefund() && $orderPayment->getAmountPaid() > $orderPayment->getAmountRefunded() || $orderPayment->canRefund() && !$this->getInvoice()->getIsUsedForRefund())) { |
There was a problem hiding this comment.
This is also way too long to process. Can refactor do these in a seperate line?
There was a problem hiding this comment.
I'll check all long lines later.
There was a problem hiding this comment.
Agreed. It would be nice if after a certain character cutoff Rector could stack conditions vertically for better readability.
There was a problem hiding this comment.
I hoped php-cs-fixer would jump in to fix it, but seems i have to do it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.