Skip to content

Added empiricompany/openmage_ignition as dependency #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 107 commits into from
Closed

Added empiricompany/openmage_ignition as dependency #4799

wants to merge 107 commits into from

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented May 5, 2025

I am not a fan of adding more and more features, but this should be in by default.

https://github.com/empiricompany/openmage_ignition/

(and ... we have added an event to make that work. use it :))

sreichel and others added 30 commits February 3, 2024 09:13
@sreichel
DDEV: added cronjob
9549482
@sreichel
Merge branch 'main' into ddev-cron
9e5c7d8
@sreichel
Fix install with dev-mode ON
8330bce
@sreichel
Update FUNDING.yml
f752180
@sreichel
Merge pull request #1 from sreichel/fix-install-devmode-on
21a9787 
FIX: install with dev-mode ON
@sreichel
Removed files added by ddev get ddev/ddev-cron
cdae0cb
@sreichel
Merge pull request #2 from sreichel/ddev-cron
9e74f9a 
DDEV: added cron
@sreichel
PHP8: fixes passing null in Mage_Adminhtml_Block_Customer_Edit_Tab_Wi…
ccd40a5 
…shlist_Grid_Renderer_Description::render()
@sreichel
Merge pull request #3 from sreichel/sreichel-funding
a6d5d9e 
Update FUNDING.yml
@sreichel
Merge pull request #5 from sreichel/om-fix-3828
d59529b 
PHP8: fixes passing null in `Mage_Adminhtml_Block_Customer_Edit_Tab_Wishlist_Grid_Renderer_Description::render()`
@sreichel
PHP8: fixes passing null in `Mage_Adminhtml_Block_System_Convert_Gui_…
c562b79 
…Edit_Tab_Wizard::getValue()` (#6)

* PHP8: fixes passing null in Mage_Adminhtml_Block_System_Convert_Gui_Edit_Tab_Wizard::getValue()

* Added docblock to template
@sreichel
Fixes OpenMage#3716 (#7)
8839d3f 
- changed with to 330px for textarea, text & select fields
- updated README.md
@sreichel
Updated PhpUnit test (#10)
16167e3 
* Test: removed Testfield b/c it does not work locally

* Test: updated workflow

* Test: updated workflow ... removed composer validation (for now)

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ...

* Test: updated workflow ... will fail

* Test: updated workflow ... added DB/install

* Test: updated workflow ...

* Test: updated workflow ...

* Remove gitpod running php73

* Remove docker install running php82

* Test: moved tests to root (as common practice)

* Test: updated workflow ... bootstrap.php

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... test

* Test: updated workflow ... sonar config

* Test: updated workflow ... phpunit.xml.dist

* Test: updated workflow ... sonar workflow

* Test: updated workflow ... phpunit.yml

* Test: updated workflow ... gitignore [skip ci]

* Test: ddev shortcut [skip ci]

* Test: updated workflow ... gitignore [skip ci]

* Test: updated workflow ... gitignore [skip ci]
@sreichel
PHP8: fixes passing null to `Mage_Downloadable_Helper_File::getFilePa…
38e3480 
…th()` (#8)

* Fixes OpenMage/magento-lts#OpenMage#3619

* Renamed test

* Fixed test

* Removed tests here ...
@sreichel
Revert: move tests back to dev directory (#11)
923148f 
* Revert "Test: moved tests to root (as common practice)"

This reverts commit 29b1e43.

* Revert "Remove docker install running php82"

This reverts commit 1fd3702.

* Revert "Remove gitpod running php73"

This reverts commit e4baf37.

* Move tests back to dev directory

* Fixed paths
@sreichel @colinmollenhour
@kiatng @addison74 @ma4nn @justinbeaty
Sync OpenMage (#12)
d6d0d8d 
* Added production-grade nginx and Docker environment (OpenMage#1209)

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

* Fixed branch names in code-ql workflow (OpenMage#3832)

* Added DDEV cronjob file (OpenMage#3831)

Co-authored-by: Sven Reichel <github-sr@hotmail.com>

* Updated the existing DDEV documentation (OpenMage#3830)

* Updated image in the DDEV's doc

* Fixed deprecation warning if downloadable sample is a url (OpenMage#3619)

* New feature: UI to list and remove orphaned ACL resources in backend. (OpenMage#3647)

Co-authored-by: Sven Reichel <github-sr@hotmail.com>
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>

* New feature: Allow admin to create guest orders and reorder as guest (OpenMage#2233)

* Allow admin guest order and reorder
* PHPCS

---------

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>

---------

Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: ADDISON <8360474+ADDISON74@users.noreply.github.com>
Co-authored-by: Christoph Massmann <c.massmann@vianetz.com>
Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
@sreichel
Merge branch 'main' into main
5d1366a
@sreichel @colinmollenhour
@kiatng @addison74 @ma4nn @justinbeaty
Sync OpneMage (#13)
6647256 
* Added production-grade nginx and Docker environment (OpenMage#1209)

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

* Fixed branch names in code-ql workflow (OpenMage#3832)

* Added DDEV cronjob file (OpenMage#3831)

Co-authored-by: Sven Reichel <github-sr@hotmail.com>

* Updated the existing DDEV documentation (OpenMage#3830)

* Updated image in the DDEV's doc

* Fixed deprecation warning if downloadable sample is a url (OpenMage#3619)

* New feature: UI to list and remove orphaned ACL resources in backend. (OpenMage#3647)

Co-authored-by: Sven Reichel <github-sr@hotmail.com>
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>

* New feature: Allow admin to create guest orders and reorder as guest (OpenMage#2233)

* Allow admin guest order and reorder
* PHPCS

---------

Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>

---------

Co-authored-by: Colin Mollenhour <colin@mollenhour.com>
Co-authored-by: Fabrizio Balliano <fabrizio.balliano@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: ADDISON <8360474+ADDISON74@users.noreply.github.com>
Co-authored-by: Christoph Massmann <c.massmann@vianetz.com>
Co-authored-by: Justin Beaty <51970393+justinbeaty@users.noreply.github.com>
@sreichel
Fix;: return correct php.ini value w/o unit set (#16)
6df1405 
* Return numeric php.ini value

* Fixed comparison
@sreichel
Merge branch 'OpenMage:main' into main
ab6cf6f
@sreichel
Merge branch 'openmage-strict:main' into main
1f8730f
@sreichel
Merge branch 'OpenMage:main' into main
63b5a7b
@sreichel
Merge branch 'openmage-strict:main' into main
267d83a
@sreichel
Sort order grid columns (#17)
370d981
@sreichel
Merge branch 'OpenMage:main' into main
633b9eb
@sreichel
Merge branch 'openmage-strict:main' into main
0fe2d71
@sreichel
Updated Varien_Object::getData() and added getDataByKey() & `getD…
15eb83f 
…ataByPath()` (#18)

* Add test for Varien_Object ... coverage 100%

* Add test for Varien_Object ... coverage 100% (2)

* Updated getData(), see OpenMage#3245

* Fixed path in sonar test

* Fixed path in sonar test

* Fixed typos

* Sonar fixes

* Fixed path in sonar test

* Fixed path in sonar test
@dependabot
Bump squizlabs/php_codesniffer from 3.8.1 to 3.9.0 (#19)
f944168 
Bumps [squizlabs/php_codesniffer](https://github.com/PHPCSStandards/PHP_CodeSniffer) from 3.8.1 to 3.9.0.
- [Release notes](https://github.com/PHPCSStandards/PHP_CodeSniffer/releases)
- [Changelog](https://github.com/PHPCSStandards/PHP_CodeSniffer/blob/master/CHANGELOG.md)
- [Commits](PHPCSStandards/PHP_CodeSniffer@3.8.1...3.9.0)

---
updated-dependencies:
- dependency-name: squizlabs/php_codesniffer
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @sreichel
Bump phpstan/phpstan from 1.10.57 to 1.10.58 (#20)
e0216d9 
* Bump phpstan/phpstan from 1.10.57 to 1.10.58

Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.10.57 to 1.10.58.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/1.11.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.10.57...1.10.58)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Fixed typo

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sven Reichel <github-sr@hotmail.com>
@sreichel
PHP8: fixes deprecated passing null in Varien_Object::toString() (#21)
369eca1
@github-actions github-actions bot added environment Component: lib/Varien Relates to lib/Varien Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: Payment Relates to Mage_Payment Component: lib/* Relates to lib/* composer Relates to composer.json phpunit labels May 5, 2025
@sreichel sreichel marked this pull request as draft May 5, 2025 02:50
@sreichel sreichel closed this May 5, 2025
@sreichel sreichel deleted the ignition branch May 5, 2025 02:50
@empiricompany
Copy link
Contributor

empiricompany commented May 5, 2025

@sreichel I don't understand this and other PRs opened and closed immediately after.

@sreichel
Copy link
Contributor Author

sreichel commented May 5, 2025

Something went wrong, see commit history. There will be a new PR.

@sreichel
Copy link
Contributor Author

sreichel commented May 5, 2025

@sreichel I don't understand this and other PRs opened and closed immediately after.

Erm, when you agree with that PR, please add it on your own 😛

Why should I add your code? 👍

@sreichel sreichel mentioned this pull request May 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Payment Relates to Mage_Payment composer Relates to composer.json environment phpunit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sreichel @empiricompany