Skip to content

Conversation

@sreichel
Copy link
Contributor

@sreichel sreichel commented Apr 19, 2025

Description (*)

Starting E2E test with cypress

I have only added some basic tests, some related to past issues/PRs ...

  • some JS form validation (works in front- and backend)
  • check for form_key existence
  • check if admin menu has correct "active" class
  • check content lenght for advanced search
  • ...
  • added to github workflow

Related Pull Requests

Manual testing scenarios (*)

  1. install DDEV
  2. install cypress-addon
  3. run
  • ddev cypress-open --config-file .cypress.config.js for browser
  • ddev cypress-run --config-file .cypress.config.js for CLI

Questions or comments

I thinks its easy to use and write tests ... maybe we can add it to our workflow to make issues/fixes reproducable.

@github-actions github-actions bot added the git label Apr 19, 2025
@sreichel
Copy link
Contributor Author

Code-changes:

  • added html-id to confog sections (for better access)
  • fix: added missing icon-head css class
  • fix: impoved validation for sitemap priority config setting

Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, this is going to be a huge improvement to being able to push more code and have fewer regressions.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@addison74 addison74 merged commit 07bb0c3 into OpenMage:main Apr 25, 2025
23 checks passed
@sreichel sreichel deleted the cypress-test branch April 25, 2025 19:25
fballiano added a commit to MahoCommerce/maho that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Adminhtml Relates to Mage_Adminhtml Component: Sitemap Relates to Mage_Sitemap environment git new feature Template : admin Relates to admin template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants