fix backend missing-shard-idx bug which causes incorrect context inde… #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x when visualizing top acts
dest1n1s
reviewed
Feb 18, 2025
server/app.py
Outdated
| @@ -41,12 +42,12 @@ def get_model(name: str) -> HookedTransformer: | |||
| return lm_cache[name] | |||
|
|
|||
|
|
|||
| def get_dataset(name: str) -> Dataset: | |||
| def get_dataset(name: str, shard_idx: int = 0, n_shards: int = 1) -> Dataset: | |||
| cfg = client.get_dataset_cfg(name) | |||
| assert cfg is not None, f"Dataset {name} not found" | |||
| if name not in dataset_cache: | |||
There was a problem hiding this comment.
Seems should be (name, shard_idx, n_shards) not in dataset_cache?
dest1n1s
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x when visualizing top acts