Skip to content

fix(analyze): misc things stopping analysis working #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 18, 2025
Merged

fix(analyze): misc things stopping analysis working #92

merged 3 commits into from
Feb 18, 2025

Conversation

dest1n1s
Copy link
Member

This PR fixes:

  • loading cached 2d activation with an extra batch dimension
  • loading mixcoder state dict in strict mode
  • supporting for mixcoder analysis
  • listing SAEs with at least one analysis
  • removing text and origins out of scope in analysis

Some issues remain to make things work correctly include:

  • explicitly set ignored token feature acts to 0 in analysis
  • load correct shards of datasets in server

@Hzfinfdu Hzfinfdu merged commit 56a80d8 into main Feb 18, 2025
2 checks passed
@Hzfinfdu Hzfinfdu deleted the fix-analysis branch February 19, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hzfinfdu Hzfinfdu Hzfinfdu approved these changes

@Frankstein73 Frankstein73 Awaiting requested review from Frankstein73

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dest1n1s @Hzfinfdu