-
Notifications
You must be signed in to change notification settings - Fork 2
Web build with emscripten #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch fmt so that it can be compiled with emscripten
Code Coverage Summary
Results for commit: 90654f6 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
this add localstorage access, and logging to console and uses that with the wrapping code correctly
…c++ works correctly in all cases
…ially overwritten
it linked both .js and .html at the same time, so the wasm was corrupt at the end also add a test for correct wasm files
some have -mt, some have the format name in it, so cover all that cases only use mp3 as music format
also convert the mgerhold.jpg to png
it had an issue with the thread, see the listed github issues, in the section where local patches are applied
support NOT prerendred text, so that no texture is created in a pthread correctly exit in the cases, where it is needed correctly stub out local storage, and the music manager
this requires storing a web context on the application instance and make it available via service provider this required a few small refactors in the apis, that use the local storage (since it only can be accessed via main thread)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.