Skip to content

Support HTTP on every platfom #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 23, 2024
Merged

Support HTTP on every platfom #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1cddf73
build: add fallback for cpp-httplib, a c++ curl wrapper
Totto16 Oct 22, 2024
4a9c552
feat: add generic interface for the http client
Totto16 Oct 23, 2024
ebb834c
fix: httplib http backend: don't use namespace in cpp
Totto16 Oct 23, 2024
2221570
feat: add curl / cpr (c++ curl wrapper) http backend
Totto16 Oct 23, 2024
1c84c21
fix: fix a few minor issues regarding the curl http backend
Totto16 Oct 23, 2024
8a1c7fb
ci: ignore files, that can't be checked, since the header is missing
Totto16 Oct 23, 2024
f89fb41
dependencies: update cpr (curl c++ wrapper) tto 1.11.0
Totto16 Oct 23, 2024
2d068f9
fix: fix curl http backend, after update of cpr
Totto16 Oct 23, 2024
fe35a25
fix: suppress warning for 3ds in cpr
Totto16 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# taken from https://github.com/cpp-linter/cpp-linter-action/blob/main/demo/.clang-tidy
---
Checks: "clang-diagnostic-*,clang-analyzer-*,bugprone-*,misc-*,performance-*,readability-*,portability-*,modernize-*,cppcoreguidelines-*,google-*,llvm-*,cert-*,-modernize-use-trailing-return-type,-bugprone-argument-comment,-misc-include-cleaner,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-readability-avoid-nested-conditional-operator,-llvm-namespace-comment,-llvm-header-guard"
Checks: "clang-diagnostic-*,clang-analyzer-*,bugprone-*,misc-*,performance-*,readability-*,portability-*,modernize-*,cppcoreguidelines-*,google-*,llvm-*,cert-*,-modernize-use-trailing-return-type,-bugprone-argument-comment,-misc-include-cleaner,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-readability-avoid-nested-conditional-operator,-llvm-namespace-comment,-llvm-header-guard,-google-build-explicit-make-pair"
WarningsAsErrors: ""
HeaderFilterRegex: "oopetris/src/.*"
FormatStyle: "file"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cpp-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
tidy-checks: ''
step-summary: true
file-annotations: true
ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|wrapper|src/libs/core/hash-library
ignore: subprojects|build|android|assets|recordings|docs|toolchains|platforms|wrapper|src/libs/core/hash-library|src/lobby/curl_client.*

- name: Fail CI run if linter checks failed
if: steps.linter.outputs.checks-failed != 0
Expand Down
2 changes: 0 additions & 2 deletions src/helper/graphic_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ std::vector<std::string> utils::supported_features() {

std::vector<std::string> features{};

#if !defined(_ONLINE_MULTIPLAYER_NOT_SUPPORTED)
features.emplace_back("online multiplayer");
#endif

#if defined(_HAVE_FILE_DIALOGS)
features.emplace_back("file dialogs");
Expand Down
Loading
Loading