Fix known bugs #159
Merged
Fix known bugs #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this was caused by not offset events in a scroll layout, it's fixed, by providing a correct implementation of handle_focus_change_events for scroll_layout, since it differs from the generic one for focus_layouts - add boolean that represents the mouse capture state of a slider - factor our the handle_event function for focus_layouts, where it is the same
…ality is no pointer event, so it has to be handled separately
|
Code Coverage SummaryResults for commit: 401cb1f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
- handle wheel input as separate pointer input, that has the advantaged, that the offset already works , without needed many new changes - only support SDL_MOUSEWHEEL, since this event is dffernt than other pointer events - bump required sdl version, since some fields in SDL_MOUSEWHEEL are only there since SDl 2.26.0
always simulate at 60 fps, an exception is, when a replay says, it uses another simulation frequency (which is not part of the standard, since this is stored in the additional information section of the recording format) - we simulate 60 times per second, even if the display / render frequency may be less or more - allow faster simulation frequencies per se, since later we might add a speedup, alias play speed for recordings or similar. - since in recordings we store the simulation index it is crucial to know which simulation_frequency we used, but it's not an additional field, so that we don#t break backwards compatibility, for that I added the additional information format earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #151