Add loading screen #158
Merged
Add loading screen #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor the functionality which takes the most time, namely initializing joysticks (input manager), now it does nothing in the constructor, but we call the initialization later, while showing the loading screen, this is needed, since some thing need to be initialized, for the loading screent o work - use SDL_GetTicks64 instead of SDL_GetTicks - show the loading screen in the application
…n exiting while loading things
…y but it's the easiest way to do the job, and the loading screen shoudln't take ages, so it likely want be cancelled all the time
- make the animation better looking - fix the drawing by using correct parameters for the render_mino function - reset the background each frame, by overdrawing it
|
Code Coverage SummaryResults for commit: e9f91c7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
- load more resources / manager in there - InputManager, go back to constructor initialization
- actually display the logo in the loading screen
…t chrono data types
Totto16
force-pushed
the
add-loading-screen
branch
from
9b4b2f7 to
e9f91c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a loading screen (since initializing the joysticks takes longer than 500 ms)
It is kept simple:
