-
Notifications
You must be signed in to change notification settings - Fork 2
Add Windows installer #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Results for commit: d03bfa7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
2fa8127
to
fe037fd
Compare
fe037fd
to
6e62fda
Compare
- use bigger icon - also set the unistaller icon
- add start menu entry - remove optional desktop shortcut - correctly track optional installed features - use registry keys better - don't make the app hidden
- also install settings to correct location, don't override old ones - refactor the directoyr finding in installer builds
…ions, it is disabled by default and by the by the default settings file
- add a seperate not required componenent, to install music files - add information for windows intor the registry, so tha the uninstall feature of windows works as intended
83d3888
to
95b6258
Compare
- also install the c++ Redist. Runtime Libraries
95b6258
to
d03bfa7
Compare
This was referenced May 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO list:
CI build failures are related to gcc-14 silent upgrades and other things, that will be resolved in #149