[kotlin][moshi] add polymorphic support with sealed classes #9193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is almost the same PR as #9159 but it also adds support for sealed classes together with moshi. It will also resolve the issue #8059. I created a separate PR because the changes of my old PR are mostly in the templates (and straight forward). I think this one is a bit more complex, so it make sense to merge the other one first.
Currently it's not possible to use Kotlin and Moshi with the oneOf-Keyword. I tried to implement the
PolymorphicJsonAdapterFactory
to support this feature.The reason why I set the target branch to
master
is because the current strategy will fail during runtime (it's not allowed with moshi to serialize a interface directly).I tested it with the following config:
Saddly in the current petstore samples are no discriminator, that's why I didn't add a sample.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
,5.1.x
,6.0.x
technical committee : @jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m