Skip to content

[kotlin][moshi] add polymorphic support #9159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,7 @@
import static java.util.Collections.sort;

import org.apache.commons.lang3.StringUtils;
import org.openapitools.codegen.CliOption;
import org.openapitools.codegen.CodegenConstants;
import org.openapitools.codegen.CodegenModel;
import org.openapitools.codegen.CodegenOperation;
import org.openapitools.codegen.CodegenParameter;
import org.openapitools.codegen.CodegenProperty;
import org.openapitools.codegen.CodegenType;
import org.openapitools.codegen.SupportingFile;
import org.openapitools.codegen.*;
import org.openapitools.codegen.meta.features.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand Down Expand Up @@ -62,6 +55,7 @@ public class KotlinClientCodegen extends AbstractKotlinCodegen {
public static final String COLLECTION_TYPE = "collectionType";

protected static final String VENDOR_EXTENSION_BASE_NAME_LITERAL = "x-base-name-literal";
protected static final String VENDOR_EXTENSION_DISCRIMINATOR_BASE_NAME_LITERAL = "x-base-name-discriminator-literal";

protected String dateLibrary = DateLibrary.JAVA8.value;
protected String requestDateConverter = RequestDateConverter.TO_JSON.value;
Expand Down Expand Up @@ -618,6 +612,11 @@ public Map<String, Object> postProcessModels(Map<String, Object> objs) {
for (CodegenProperty var : vars) {
var.vendorExtensions.put(VENDOR_EXTENSION_BASE_NAME_LITERAL, var.baseName.replace("$", "\\$"));
}

CodegenDiscriminator discriminator = cm.getDiscriminator();
if(discriminator != null) {
cm.vendorExtensions.put(VENDOR_EXTENSION_DISCRIMINATOR_BASE_NAME_LITERAL, discriminator.getPropertyBaseName().replace("$", "\\$"));
}
}

return objects;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ buildscript {
{{#useRxJava3}}
ext.rxJava3Version = '3.0.10'
{{/useRxJava3}}
{{#moshi}}
ext.moshiVersion = '1.11.0'
{{/moshi}}

repositories {
maven { url "https://repo1.maven.org/maven2" }
Expand Down Expand Up @@ -56,12 +59,13 @@ dependencies {
{{#moshi}}
{{^moshiCodeGen}}
compile "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
compile "com.squareup.moshi:moshi-kotlin:1.11.0"
compile "com.squareup.moshi:moshi-kotlin:$moshiVersion"
{{/moshiCodeGen}}
{{#moshiCodeGen}}
compile "com.squareup.moshi:moshi:1.11.0"
kapt "com.squareup.moshi:moshi-kotlin-codegen:1.11.0"
compile "com.squareup.moshi:moshi:$moshiVersion"
kapt "com.squareup.moshi:moshi-kotlin-codegen:$moshiVersion"
{{/moshiCodeGen}}
compile "com.squareup.moshi:moshi-adapters:$moshiVersion"
{{/moshi}}
{{#gson}}
compile "com.google.code.gson:gson:2.8.6"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ import java.io.Serializable
{{#parcelizeModels}}
@Parcelize
{{/parcelizeModels}}
{{#multiplatform}}@Serializable{{/multiplatform}}{{#kotlinx_serialization}}{{#serializableModel}}@KSerializable{{/serializableModel}}{{^serializableModel}}@Serializable{{/serializableModel}}{{/kotlinx_serialization}}{{#moshi}}{{#moshiCodeGen}}@JsonClass(generateAdapter = true){{/moshiCodeGen}}{{/moshi}}{{#jackson}}{{#discriminator}}{{>typeInfoAnnotation}}{{/discriminator}}{{/jackson}}
{{#multiplatform}}@Serializable{{/multiplatform}}{{#kotlinx_serialization}}{{#serializableModel}}@KSerializable{{/serializableModel}}{{^serializableModel}}@Serializable{{/serializableModel}}{{/kotlinx_serialization}}{{#moshi}}{{^discriminator}}{{#moshiCodeGen}}@JsonClass(generateAdapter = true){{/moshiCodeGen}}{{/discriminator}}{{/moshi}}{{#jackson}}{{#discriminator}}{{>typeInfoAnnotation}}{{/discriminator}}{{/jackson}}
{{#isDeprecated}}
@Deprecated(message = "This schema is deprecated.")
{{/isDeprecated}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
{{/description}}
{{^multiplatform}}
{{#moshi}}
@Json(name = "{{{vendorExtensions.x-base-name-literal}}}")
{{^discriminator}}@Json(name = "{{{vendorExtensions.x-base-name-literal}}}"){{/discriminator}}
{{/moshi}}
{{#gson}}
@get:SerializedName("{{{vendorExtensions.x-base-name-literal}}}")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package {{packageName}}.infrastructure

{{#moshi}}
import com.squareup.moshi.Moshi
import com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory
{{^moshiCodeGen}}
import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
{{/moshiCodeGen}}
Expand Down Expand Up @@ -51,6 +52,10 @@ import java.util.concurrent.atomic.AtomicInteger
import java.util.concurrent.atomic.AtomicLong
{{/kotlinx_serialization}}

{{#moshi}}
import {{modelPackage}}.*
{{/moshi}}

{{#nonPublicApi}}internal {{/nonPublicApi}}object Serializer {
{{#moshi}}
@JvmStatic
Expand All @@ -60,11 +65,16 @@ import java.util.concurrent.atomic.AtomicLong
.add(LocalDateAdapter())
.add(UUIDAdapter())
.add(ByteArrayAdapter())
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())
{{^moshiCodeGen}}
.add(KotlinJsonAdapterFactory())
{{/moshiCodeGen}}
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())
{{#models}}{{#model}}{{#discriminator}}.add(PolymorphicJsonAdapterFactory.of({{classname}}::class.java, "{{{vendorExtensions.x-base-name-discriminator-literal}}}")
{{#mappedModels}}
.withSubtype({{modelName}}::class.java, "{{mappingName}}")
{{/mappedModels}}
){{/discriminator}}{{/model}}{{/models}}

@JvmStatic
val moshi: Moshi by lazy {
Expand All @@ -78,7 +88,7 @@ import java.util.concurrent.atomic.AtomicLong
.registerTypeAdapter(LocalDateTime::class.java, LocalDateTimeAdapter())
.registerTypeAdapter(LocalDate::class.java, LocalDateAdapter())
.registerTypeAdapter(ByteArray::class.java, ByteArrayAdapter())

@JvmStatic
val gson: Gson by lazy {
gsonBuilder.create()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ import java.time.OffsetDateTime
import java.util.UUID
import java.util.Date


object Serializer {
@JvmStatic
val gsonBuilder: GsonBuilder = GsonBuilder()
.registerTypeAdapter(OffsetDateTime::class.java, OffsetDateTimeAdapter())
.registerTypeAdapter(LocalDateTime::class.java, LocalDateTimeAdapter())
.registerTypeAdapter(LocalDate::class.java, LocalDateAdapter())
.registerTypeAdapter(ByteArray::class.java, ByteArrayAdapter())

@JvmStatic
val gson: Gson by lazy {
gsonBuilder.create()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import com.fasterxml.jackson.annotation.JsonInclude
import com.fasterxml.jackson.module.kotlin.jacksonObjectMapper
import java.util.Date


object Serializer {
@JvmStatic
val jacksonObjectMapper: ObjectMapper = jacksonObjectMapper()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ wrapper {

buildscript {
ext.kotlin_version = '1.4.30'
ext.moshiVersion = '1.11.0'

repositories {
maven { url "https://repo1.maven.org/maven2" }
Expand All @@ -30,7 +31,8 @@ test {
dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
compile "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
compile "com.squareup.moshi:moshi-kotlin:1.11.0"
compile "com.squareup.moshi:moshi-kotlin:$moshiVersion"
compile "com.squareup.moshi:moshi-adapters:$moshiVersion"
compile "com.squareup.okhttp3:okhttp:4.9.0"
testCompile "io.kotlintest:kotlintest-runner-junit5:3.4.2"
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package org.openapitools.client.infrastructure

import com.squareup.moshi.Moshi
import com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory
import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
import java.util.Date

import org.openapitools.client.models.*

object Serializer {
@JvmStatic
val moshiBuilder: Moshi.Builder = Moshi.Builder()
Expand All @@ -12,9 +15,10 @@ object Serializer {
.add(LocalDateAdapter())
.add(UUIDAdapter())
.add(ByteArrayAdapter())
.add(KotlinJsonAdapterFactory())
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())
.add(KotlinJsonAdapterFactory())


@JvmStatic
val moshi: Moshi by lazy {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ import java.time.OffsetDateTime
import java.util.UUID
import java.util.Date


object Serializer {
@JvmStatic
val gsonBuilder: GsonBuilder = GsonBuilder()
.registerTypeAdapter(OffsetDateTime::class.java, OffsetDateTimeAdapter())
.registerTypeAdapter(LocalDateTime::class.java, LocalDateTimeAdapter())
.registerTypeAdapter(LocalDate::class.java, LocalDateAdapter())
.registerTypeAdapter(ByteArray::class.java, ByteArrayAdapter())

@JvmStatic
val gson: Gson by lazy {
gsonBuilder.create()
Expand Down
6 changes: 4 additions & 2 deletions samples/client/petstore/kotlin-moshi-codegen/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ wrapper {

buildscript {
ext.kotlin_version = '1.4.30'
ext.moshiVersion = '1.11.0'

repositories {
maven { url "https://repo1.maven.org/maven2" }
Expand All @@ -30,8 +31,9 @@ test {

dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
compile "com.squareup.moshi:moshi:1.11.0"
kapt "com.squareup.moshi:moshi-kotlin-codegen:1.11.0"
compile "com.squareup.moshi:moshi:$moshiVersion"
kapt "com.squareup.moshi:moshi-kotlin-codegen:$moshiVersion"
compile "com.squareup.moshi:moshi-adapters:$moshiVersion"
compile "com.squareup.okhttp3:okhttp:4.9.0"
testCompile "io.kotlintest:kotlintest-runner-junit5:3.4.2"
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package org.openapitools.client.infrastructure

import com.squareup.moshi.Moshi
import com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory
import java.util.Date

import org.openapitools.client.models.*

object Serializer {
@JvmStatic
val moshiBuilder: Moshi.Builder = Moshi.Builder()
Expand All @@ -13,6 +16,7 @@ object Serializer {
.add(ByteArrayAdapter())
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())


@JvmStatic
val moshi: Moshi by lazy {
Expand Down
4 changes: 3 additions & 1 deletion samples/client/petstore/kotlin-nonpublic/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ wrapper {

buildscript {
ext.kotlin_version = '1.4.30'
ext.moshiVersion = '1.11.0'

repositories {
maven { url "https://repo1.maven.org/maven2" }
Expand All @@ -30,7 +31,8 @@ test {
dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
compile "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
compile "com.squareup.moshi:moshi-kotlin:1.11.0"
compile "com.squareup.moshi:moshi-kotlin:$moshiVersion"
compile "com.squareup.moshi:moshi-adapters:$moshiVersion"
compile "com.squareup.okhttp3:okhttp:4.9.0"
testCompile "io.kotlintest:kotlintest-runner-junit5:3.4.2"
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package org.openapitools.client.infrastructure

import com.squareup.moshi.Moshi
import com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory
import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
import java.util.Date

import org.openapitools.client.models.*

internal object Serializer {
@JvmStatic
val moshiBuilder: Moshi.Builder = Moshi.Builder()
Expand All @@ -12,9 +15,10 @@ internal object Serializer {
.add(LocalDateAdapter())
.add(UUIDAdapter())
.add(ByteArrayAdapter())
.add(KotlinJsonAdapterFactory())
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())
.add(KotlinJsonAdapterFactory())


@JvmStatic
val moshi: Moshi by lazy {
Expand Down
4 changes: 3 additions & 1 deletion samples/client/petstore/kotlin-nullable/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ wrapper {

buildscript {
ext.kotlin_version = '1.4.30'
ext.moshiVersion = '1.11.0'

repositories {
maven { url "https://repo1.maven.org/maven2" }
Expand All @@ -30,7 +31,8 @@ test {
dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
compile "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
compile "com.squareup.moshi:moshi-kotlin:1.11.0"
compile "com.squareup.moshi:moshi-kotlin:$moshiVersion"
compile "com.squareup.moshi:moshi-adapters:$moshiVersion"
compile "com.squareup.okhttp3:okhttp:4.9.0"
testCompile "io.kotlintest:kotlintest-runner-junit5:3.4.2"
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package org.openapitools.client.infrastructure

import com.squareup.moshi.Moshi
import com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory
import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
import java.util.Date

import org.openapitools.client.models.*

object Serializer {
@JvmStatic
val moshiBuilder: Moshi.Builder = Moshi.Builder()
Expand All @@ -12,9 +15,10 @@ object Serializer {
.add(LocalDateAdapter())
.add(UUIDAdapter())
.add(ByteArrayAdapter())
.add(KotlinJsonAdapterFactory())
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())
.add(KotlinJsonAdapterFactory())


@JvmStatic
val moshi: Moshi by lazy {
Expand Down
4 changes: 3 additions & 1 deletion samples/client/petstore/kotlin-okhttp3/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ wrapper {

buildscript {
ext.kotlin_version = '1.4.30'
ext.moshiVersion = '1.11.0'

repositories {
maven { url "https://repo1.maven.org/maven2" }
Expand All @@ -30,7 +31,8 @@ test {
dependencies {
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
compile "org.jetbrains.kotlin:kotlin-reflect:$kotlin_version"
compile "com.squareup.moshi:moshi-kotlin:1.11.0"
compile "com.squareup.moshi:moshi-kotlin:$moshiVersion"
compile "com.squareup.moshi:moshi-adapters:$moshiVersion"
compile "com.squareup.okhttp3:okhttp:3.12.13"
testCompile "io.kotlintest:kotlintest-runner-junit5:3.4.2"
}
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
package org.openapitools.client.infrastructure

import com.squareup.moshi.Moshi
import com.squareup.moshi.adapters.PolymorphicJsonAdapterFactory
import com.squareup.moshi.kotlin.reflect.KotlinJsonAdapterFactory
import java.util.Date

import org.openapitools.client.models.*

object Serializer {
@JvmStatic
val moshiBuilder: Moshi.Builder = Moshi.Builder()
Expand All @@ -12,9 +15,10 @@ object Serializer {
.add(LocalDateAdapter())
.add(UUIDAdapter())
.add(ByteArrayAdapter())
.add(KotlinJsonAdapterFactory())
.add(BigDecimalAdapter())
.add(BigIntegerAdapter())
.add(KotlinJsonAdapterFactory())


@JvmStatic
val moshi: Moshi by lazy {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import java.util.concurrent.atomic.AtomicBoolean
import java.util.concurrent.atomic.AtomicInteger
import java.util.concurrent.atomic.AtomicLong


object Serializer {
@JvmStatic
val kotlinSerializationAdapters = SerializersModule {
Expand Down
Loading