-
-
Notifications
You must be signed in to change notification settings - Fork 7.1k
[Kotlin] Add polymorphic support for Gson #7164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Kotlin] Add polymorphic support for Gson #7164
Conversation
Based on Java-Gson generator
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Hum, is this related to my change ?
|
modules/openapi-generator/src/main/resources/kotlin-client/build.gradle.mustache
Show resolved
Hide resolved
Could this change have a flag to enable or disable this behaviour? |
I think it shouldn't, unless you have a specific use case ? |
Remove Gsonfire if no polymorphic support is needed does what I need, looks a good solution to me 👍 |
@loicsiret I was going through the old PRs and saw this one. |
pHi Bruno,
To be honest, I think it's a very important functionality for developers
using GSON. However since I created this PR, I moved to Moshi, creating
mustache files for the same functionality, and right now I working on KMP
with Kotlin serialization 😅
Best regards
Le mer. 26 mai 2021 à 05:41, Bruno Coelho ***@***.***> a
écrit :
… @loicsiret <https://github.com/loicsiret> I was going through the old PRs
and saw this one.
Are you still interested in this functionality?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7164 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7JLFQFZZTTMJVAVC5EOEDTPS65LANCNFSM4PX62P2A>
.
|
Thanks for the heads-up 🙂 |
Based on Java-Gson generator
Modify the templates files of Serializer for supporting Polymorphic in Kotlin - GSON
This is a port of the [java template]
You can check against this yaml file to validate : generic.yaml
PR checklist
./bin/generate-samples.sh
to update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH.master
FIXED #7163
cc: @jimschubert , @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m