-
-
Notifications
You must be signed in to change notification settings - Fork 7k
[swift] [urlsession] Fixes crash for uploads with content-type "image/" #21544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[swift] [urlsession] Fixes crash for uploads with content-type "image/" #21544
Conversation
Hi @Jonas1893 can you please take a look at CI? Thanks |
Can we re-trigger CI? |
Done. You can also do it, you just need to close and reopen the PR. |
@4brunu the tests always fail with a crash in xcpretty 0.4.0:
It looks like this exact issue has been fixed with 0.4.1: We need to update xcpretty to latest version. Not sure how this is been done for this project though, can you help me with this? |
Found it. Bitrise is configured using this image: https://bitrise.io/stacks/stack_reports/osx-xcode-16.0.x which has xcpretty 0.4.0 preinstalled. We need at least this image: https://bitrise.io/stacks/stack_reports/osx-xcode-16.3.x |
For the error we get during samples generation step on linux there is this open issue for setup-swift GitHub action: swift-actions/setup-swift#739 |
This reverts commit 92202dd.
Ok now I get test execution errors definitely unrelated to my change in |
Bitrise now fails while testing |
right looks the build failure itself, i'll take a look |
looks like restarting it fix the build failure as shown in #21553 |
Fixes a crash in urlsession templates if Content-Type with prefix "image/" is used for image upload. Issue -> #21539
The same issue should also be happening in Alamofire templates but there the solution doesn't look as trivial and I am not comfortable making the change without extended testing.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11) @dydus0x14 (2023/06)
Declaration
The program was tested solely for our own use cases, which might differ from yours.
Link to provider information
https://github.com/mercedes-benz