Skip to content

Removed try/catch to enable framework error handling to pick up error #21523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

holkerveen
Copy link

@ybelenko Mentioning you here as I needed to mention the relevant tech committee. as per the PR description template

I have removed the try/catch block from the controller logic in the php-laravel server generator. The reason for that is because the try/catch block is not extendable and returns a nonstandard and non-customizable response.

By removing the try/catch block we allow Laravel to pick up and handle the error. We also allow users of the generator to add their custom generator logic.

This should fix #21109 . Got no response so am now trying this route.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jul 5, 2025

thanks for the PR

please follow step 3 to update the samples

@wing328
Copy link
Member

wing328 commented Jul 5, 2025

cc @gijs-blanken (who rewrote the php laravel generator

@gijs-blanken
Copy link
Contributor

Sounds reasonable! Any specific issue you encountered that this solves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] php-laravel generator should leave exception handling to the framework
3 participants