Skip to content

Added support for multiple api keys in rust (reqwest) #19511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added support for multiple api keys in rust (reqwest) #19511

wants to merge 1 commit into from

Conversation

GeorgeFkd
Copy link
Contributor

Relevant Context:

Issue #8833 and PR #8868

A more standard approach is followed here using a Map for Api Keys as seen in C# client example

API Key prefixes support was not added in this PR, can work on it here or a separate PR.

For the example(The Rock Trading public api) provided in #8833 the code of interest produced by the generator is:

if let Some(local_var_apikey) = local_var_configuration.api_keys.get("X-TRT-SIGN") {
   let local_var_key = local_var_apikey.clone();
   local_var_req_builder = local_var_req_builder.header("X-TRT-SIGN", local_var_key);
};
if let Some(local_var_apikey) = local_var_configuration.api_keys.get("X-TRT-KEY") {
   let local_var_key = local_var_apikey.clone();
   local_var_req_builder = local_var_req_builder.header("X-TRT-KEY", local_var_key);
};
if let Some(local_var_apikey) = local_var_configuration.api_keys.get("X-TRT-NONCE") {
   let local_var_key = local_var_apikey.clone();
   local_var_req_builder = local_var_req_builder.header("X-TRT-NONCE", local_var_key);
};

Rust Technical Comittee

cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@GeorgeFkd GeorgeFkd closed this Oct 26, 2024
@GeorgeFkd GeorgeFkd deleted the fix_issue_8833 branch October 26, 2024 20:03
@wing328
Copy link
Member

wing328 commented Nov 9, 2024

thanks for the PR

but we can't merge it to master since it's a breaking change (users need to update their code accordingly to make it compile)

we need to do something like #20069

i will try to take care of it later.

thanks again for the work and sorry for the delay in getting it merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants