Skip to content

Remove @Valid even for enum types defined in components #18451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{{#required}}@NotNull {{/required}}{{^isPrimitiveType}}{{^isDate}}{{^isDateTime}}{{^isString}}{{^isFile}}@Valid {{/isFile}}{{/isString}}{{/isDateTime}}{{/isDate}}{{/isPrimitiveType}}{{>beanValidationCore}}
{{#required}}@NotNull {{/required}}{{#isContainer}}{{^items.isPrimitiveType}}{{^items.isDate}}{{^items.isDateTime}}{{^items.isString}}{{^items.isFile}}{{^items.isEnumOrRef}}@Valid {{/items.isEnumOrRef}}{{/items.isFile}}{{/items.isString}}{{/items.isDateTime}}{{/items.isDate}}{{/items.isPrimitiveType}}{{/isContainer}}{{^isContainer}}{{^isPrimitiveType}}{{^isDate}}{{^isDateTime}}{{^isString}}{{^isFile}}{{^isEnumOrRef}}@Valid {{/isEnumOrRef}}{{/isFile}}{{/isString}}{{/isDateTime}}{{/isDate}}{{/isPrimitiveType}}{{/isContainer}}{{>beanValidationCore}}
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ public Response testEndpointParameters(@ApiParam(value = "None", required=true)
@io.swagger.annotations.ApiResponse(code = 400, message = "Invalid request", response = Void.class),
@io.swagger.annotations.ApiResponse(code = 404, message = "Not found", response = Void.class)
})
public Response testEnumParameters(@ApiParam(value = "Header parameter enum test (string array)" , allowableValues=">, $")@HeaderParam("enum_header_string_array") List<String> enumHeaderStringArray,@ApiParam(value = "Header parameter enum test (string)" , allowableValues="_abc, -efg, (xyz)", defaultValue="-efg")@HeaderParam("enum_header_string") String enumHeaderString,@ApiParam(value = "Query parameter enum test (string array)") @QueryParam("enum_query_string_array") @Valid List<String> enumQueryStringArray,@ApiParam(value = "Query parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue = "-efg") @DefaultValue("-efg") @QueryParam("enum_query_string") String enumQueryString,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1, -2") @QueryParam("enum_query_integer") Integer enumQueryInteger,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1.1, -1.2") @QueryParam("enum_query_double") Double enumQueryDouble,@ApiParam(value = "Form parameter enum test (string array)", allowableValues=">, $", defaultValue="$") @DefaultValue("$") @FormParam("enum_form_string_array") List<String> enumFormStringArray,@ApiParam(value = "Form parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue="-efg") @DefaultValue("-efg") @FormParam("enum_form_string") String enumFormString,@Context SecurityContext securityContext)
public Response testEnumParameters(@ApiParam(value = "Header parameter enum test (string array)" , allowableValues=">, $")@HeaderParam("enum_header_string_array") List<String> enumHeaderStringArray,@ApiParam(value = "Header parameter enum test (string)" , allowableValues="_abc, -efg, (xyz)", defaultValue="-efg")@HeaderParam("enum_header_string") String enumHeaderString,@ApiParam(value = "Query parameter enum test (string array)") @QueryParam("enum_query_string_array") List<String> enumQueryStringArray,@ApiParam(value = "Query parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue = "-efg") @DefaultValue("-efg") @QueryParam("enum_query_string") String enumQueryString,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1, -2") @QueryParam("enum_query_integer") Integer enumQueryInteger,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1.1, -1.2") @QueryParam("enum_query_double") Double enumQueryDouble,@ApiParam(value = "Form parameter enum test (string array)", allowableValues=">, $", defaultValue="$") @DefaultValue("$") @FormParam("enum_form_string_array") List<String> enumFormStringArray,@ApiParam(value = "Form parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue="-efg") @DefaultValue("-efg") @FormParam("enum_form_string") String enumFormString,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testEnumParameters(enumHeaderStringArray, enumHeaderString, enumQueryStringArray, enumQueryString, enumQueryInteger, enumQueryDouble, enumFormStringArray, enumFormString, securityContext);
}
Expand All @@ -209,7 +209,7 @@ public Response testGroupParameters(@ApiParam(value = "Required String in group
@io.swagger.annotations.ApiResponses(value = {
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Void.class)
})
public Response testInlineAdditionalProperties(@ApiParam(value = "request body", required = true) @NotNull @Valid Map<String, String> param,@Context SecurityContext securityContext)
public Response testInlineAdditionalProperties(@ApiParam(value = "request body", required = true) @NotNull Map<String, String> param,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testInlineAdditionalProperties(param, securityContext);
}
Expand All @@ -233,7 +233,7 @@ public Response testJsonFormData(@ApiParam(value = "field1", required=true) @Fo
@io.swagger.annotations.ApiResponses(value = {
@io.swagger.annotations.ApiResponse(code = 200, message = "Success", response = Void.class)
})
public Response testQueryParameterCollectionFormat(@ApiParam(value = "", required = true) @QueryParam("pipe") @NotNull @Valid List<String> pipe,@ApiParam(value = "", required = true) @QueryParam("ioutil") @NotNull @Valid List<String> ioutil,@ApiParam(value = "", required = true) @QueryParam("http") @NotNull @Valid List<String> http,@ApiParam(value = "", required = true) @QueryParam("url") @NotNull @Valid List<String> url,@ApiParam(value = "", required = true) @QueryParam("context") @NotNull @Valid List<String> context,@Context SecurityContext securityContext)
public Response testQueryParameterCollectionFormat(@ApiParam(value = "", required = true) @QueryParam("pipe") @NotNull List<String> pipe,@ApiParam(value = "", required = true) @QueryParam("ioutil") @NotNull List<String> ioutil,@ApiParam(value = "", required = true) @QueryParam("http") @NotNull List<String> http,@ApiParam(value = "", required = true) @QueryParam("url") @NotNull List<String> url,@ApiParam(value = "", required = true) @QueryParam("context") @NotNull List<String> context,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testQueryParameterCollectionFormat(pipe, ioutil, http, url, context, securityContext);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public Response deletePet(@ApiParam(value = "Pet id to delete", required = true)
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Pet.class, responseContainer = "List"),
@io.swagger.annotations.ApiResponse(code = 400, message = "Invalid status value", response = Void.class)
})
public Response findPetsByStatus(@ApiParam(value = "Status values that need to be considered for filter", required = true) @QueryParam("status") @NotNull @Valid List<String> status,@Context SecurityContext securityContext)
public Response findPetsByStatus(@ApiParam(value = "Status values that need to be considered for filter", required = true) @QueryParam("status") @NotNull List<String> status,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.findPetsByStatus(status, securityContext);
}
Expand All @@ -125,7 +125,7 @@ public Response findPetsByStatus(@ApiParam(value = "Status values that need to b
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Pet.class, responseContainer = "Set"),
@io.swagger.annotations.ApiResponse(code = 400, message = "Invalid tag value", response = Void.class)
})
public Response findPetsByTags(@ApiParam(value = "Tags to filter by", required = true) @QueryParam("tags") @NotNull @Valid Set<String> tags,@Context SecurityContext securityContext)
public Response findPetsByTags(@ApiParam(value = "Tags to filter by", required = true) @QueryParam("tags") @NotNull Set<String> tags,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.findPetsByTags(tags, securityContext);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ public AdditionalPropertiesClass putMapArrayIntegerItem(String key, List<Integer
**/
@JsonProperty(value = "map_array_integer")
@ApiModelProperty(value = "")
@Valid

public Map<String, List<Integer>> getMapArrayInteger() {
return mapArrayInteger;
}
Expand Down Expand Up @@ -248,7 +248,7 @@ public AdditionalPropertiesClass putMapArrayAnytypeItem(String key, List<Object>
**/
@JsonProperty(value = "map_array_anytype")
@ApiModelProperty(value = "")
@Valid

public Map<String, List<Object>> getMapArrayAnytype() {
return mapArrayAnytype;
}
Expand Down Expand Up @@ -276,7 +276,7 @@ public AdditionalPropertiesClass putMapMapStringItem(String key, Map<String, Str
**/
@JsonProperty(value = "map_map_string")
@ApiModelProperty(value = "")
@Valid

public Map<String, Map<String, String>> getMapMapString() {
return mapMapString;
}
Expand Down Expand Up @@ -304,7 +304,7 @@ public AdditionalPropertiesClass putMapMapAnytypeItem(String key, Map<String, Ob
**/
@JsonProperty(value = "map_map_anytype")
@ApiModelProperty(value = "")
@Valid

public Map<String, Map<String, Object>> getMapMapAnytype() {
return mapMapAnytype;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public ArrayTest addArrayArrayOfIntegerItem(List<Long> arrayArrayOfIntegerItem)
**/
@JsonProperty(value = "array_array_of_integer")
@ApiModelProperty(value = "")
@Valid

public List<List<Long>> getArrayArrayOfInteger() {
return arrayArrayOfInteger;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ public EnumTest outerEnum(OuterEnum outerEnum) {
**/
@JsonProperty(value = "outerEnum")
@ApiModelProperty(value = "")
@Valid

public OuterEnum getOuterEnum() {
return outerEnum;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ public MapTest putMapMapOfStringItem(String key, Map<String, String> mapMapOfStr
**/
@JsonProperty(value = "map_map_of_string")
@ApiModelProperty(value = "")
@Valid

public Map<String, Map<String, String>> getMapMapOfString() {
return mapMapOfString;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public Response fakePropertyEnumIntegerSerialize(@ApiParam(value = "Input enum (
@io.swagger.annotations.ApiResponses(value = {
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Void.class)
})
public Response testAdditionalPropertiesReference(@ApiParam(value = "request body", required = true) @NotNull @Valid Map<String, Object> requestBody,@Context SecurityContext securityContext)
public Response testAdditionalPropertiesReference(@ApiParam(value = "request body", required = true) @NotNull Map<String, Object> requestBody,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testAdditionalPropertiesReference(requestBody, securityContext);
}
Expand Down Expand Up @@ -252,7 +252,7 @@ public Response testEndpointParameters(@ApiParam(value = "None", required=true)
@io.swagger.annotations.ApiResponse(code = 400, message = "Invalid request", response = Void.class),
@io.swagger.annotations.ApiResponse(code = 404, message = "Not found", response = Void.class)
})
public Response testEnumParameters(@ApiParam(value = "Header parameter enum test (string array)" , allowableValues=">, $")@HeaderParam("enum_header_string_array") List<String> enumHeaderStringArray,@ApiParam(value = "Header parameter enum test (string)" , allowableValues="_abc, -efg, (xyz)", defaultValue="-efg")@HeaderParam("enum_header_string") String enumHeaderString,@ApiParam(value = "Query parameter enum test (string array)") @QueryParam("enum_query_string_array") @Valid List<String> enumQueryStringArray,@ApiParam(value = "Query parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue = "-efg") @DefaultValue("-efg") @QueryParam("enum_query_string") String enumQueryString,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1, -2") @QueryParam("enum_query_integer") Integer enumQueryInteger,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1.1, -1.2") @QueryParam("enum_query_double") Double enumQueryDouble,@ApiParam(value = "") @QueryParam("enum_query_model_array") @Valid List<EnumClass> enumQueryModelArray,@ApiParam(value = "Form parameter enum test (string array)", allowableValues=">, $", defaultValue="$") @DefaultValue("$") @FormParam("enum_form_string_array") List<String> enumFormStringArray,@ApiParam(value = "Form parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue="-efg") @DefaultValue("-efg") @FormParam("enum_form_string") String enumFormString,@Context SecurityContext securityContext)
public Response testEnumParameters(@ApiParam(value = "Header parameter enum test (string array)" , allowableValues=">, $")@HeaderParam("enum_header_string_array") List<String> enumHeaderStringArray,@ApiParam(value = "Header parameter enum test (string)" , allowableValues="_abc, -efg, (xyz)", defaultValue="-efg")@HeaderParam("enum_header_string") String enumHeaderString,@ApiParam(value = "Query parameter enum test (string array)") @QueryParam("enum_query_string_array") List<String> enumQueryStringArray,@ApiParam(value = "Query parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue = "-efg") @DefaultValue("-efg") @QueryParam("enum_query_string") String enumQueryString,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1, -2") @QueryParam("enum_query_integer") Integer enumQueryInteger,@ApiParam(value = "Query parameter enum test (double)", allowableValues="1.1, -1.2") @QueryParam("enum_query_double") Double enumQueryDouble,@ApiParam(value = "") @QueryParam("enum_query_model_array") List<EnumClass> enumQueryModelArray,@ApiParam(value = "Form parameter enum test (string array)", allowableValues=">, $", defaultValue="$") @DefaultValue("$") @FormParam("enum_form_string_array") List<String> enumFormStringArray,@ApiParam(value = "Form parameter enum test (string)", allowableValues="_abc, -efg, (xyz)", defaultValue="-efg") @DefaultValue("-efg") @FormParam("enum_form_string") String enumFormString,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testEnumParameters(enumHeaderStringArray, enumHeaderString, enumQueryStringArray, enumQueryString, enumQueryInteger, enumQueryDouble, enumQueryModelArray, enumFormStringArray, enumFormString, securityContext);
}
Expand All @@ -278,7 +278,7 @@ public Response testGroupParameters(@ApiParam(value = "Required String in group
@io.swagger.annotations.ApiResponses(value = {
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Void.class)
})
public Response testInlineAdditionalProperties(@ApiParam(value = "request body", required = true) @NotNull @Valid Map<String, String> requestBody,@Context SecurityContext securityContext)
public Response testInlineAdditionalProperties(@ApiParam(value = "request body", required = true) @NotNull Map<String, String> requestBody,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testInlineAdditionalProperties(requestBody, securityContext);
}
Expand Down Expand Up @@ -326,7 +326,7 @@ public Response testNullable(@ApiParam(value = "request body", required = true)
@io.swagger.annotations.ApiResponses(value = {
@io.swagger.annotations.ApiResponse(code = 200, message = "Success", response = Void.class)
})
public Response testQueryParameterCollectionFormat(@ApiParam(value = "", required = true) @QueryParam("pipe") @NotNull @Valid List<String> pipe,@ApiParam(value = "", required = true) @QueryParam("ioutil") @NotNull @Valid List<String> ioutil,@ApiParam(value = "", required = true) @QueryParam("http") @NotNull @Valid List<String> http,@ApiParam(value = "", required = true) @QueryParam("url") @NotNull @Valid List<String> url,@ApiParam(value = "", required = true) @QueryParam("context") @NotNull @Valid List<String> context,@ApiParam(value = "", required = true) @QueryParam("allowEmpty") @NotNull String allowEmpty,@ApiParam(value = "") @QueryParam("language") @Valid Map<String, String> language,@Context SecurityContext securityContext)
public Response testQueryParameterCollectionFormat(@ApiParam(value = "", required = true) @QueryParam("pipe") @NotNull List<String> pipe,@ApiParam(value = "", required = true) @QueryParam("ioutil") @NotNull List<String> ioutil,@ApiParam(value = "", required = true) @QueryParam("http") @NotNull List<String> http,@ApiParam(value = "", required = true) @QueryParam("url") @NotNull List<String> url,@ApiParam(value = "", required = true) @QueryParam("context") @NotNull List<String> context,@ApiParam(value = "", required = true) @QueryParam("allowEmpty") @NotNull String allowEmpty,@ApiParam(value = "") @QueryParam("language") Map<String, String> language,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testQueryParameterCollectionFormat(pipe, ioutil, http, url, context, allowEmpty, language, securityContext);
}
Expand All @@ -338,7 +338,7 @@ public Response testQueryParameterCollectionFormat(@ApiParam(value = "", require
@io.swagger.annotations.ApiResponses(value = {
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Void.class)
})
public Response testStringMapReference(@ApiParam(value = "request body", required = true) @NotNull @Valid Map<String, String> requestBody,@Context SecurityContext securityContext)
public Response testStringMapReference(@ApiParam(value = "request body", required = true) @NotNull Map<String, String> requestBody,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.testStringMapReference(requestBody, securityContext);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ public Response deletePet(@ApiParam(value = "Pet id to delete", required = true)
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Pet.class, responseContainer = "List"),
@io.swagger.annotations.ApiResponse(code = 400, message = "Invalid status value", response = Void.class)
})
public Response findPetsByStatus(@ApiParam(value = "Status values that need to be considered for filter", required = true) @QueryParam("status") @NotNull @Valid List<String> status,@Context SecurityContext securityContext)
public Response findPetsByStatus(@ApiParam(value = "Status values that need to be considered for filter", required = true) @QueryParam("status") @NotNull List<String> status,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.findPetsByStatus(status, securityContext);
}
Expand All @@ -125,7 +125,7 @@ public Response findPetsByStatus(@ApiParam(value = "Status values that need to b
@io.swagger.annotations.ApiResponse(code = 200, message = "successful operation", response = Pet.class, responseContainer = "Set"),
@io.swagger.annotations.ApiResponse(code = 400, message = "Invalid tag value", response = Void.class)
})
public Response findPetsByTags(@ApiParam(value = "Tags to filter by", required = true) @QueryParam("tags") @NotNull @Valid Set<String> tags,@Context SecurityContext securityContext)
public Response findPetsByTags(@ApiParam(value = "Tags to filter by", required = true) @QueryParam("tags") @NotNull Set<String> tags,@Context SecurityContext securityContext)
throws NotFoundException {
return delegate.findPetsByTags(tags, securityContext);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public AdditionalPropertiesClass putMapOfMapPropertyItem(String key, Map<String,
**/
@JsonProperty(value = "map_of_map_property")
@ApiModelProperty(value = "")
@Valid

public Map<String, Map<String, String>> getMapOfMapProperty() {
return mapOfMapProperty;
}
Expand Down
Loading