fix: remove <any> from enum declaration #16173
Open
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Currently the enum values generated through the
typescript-node
generator are typed as . They get outputted like so:But there seems to be no apparent reason as to why is being used. Note that the last change to this line was 5 years ago, so there might have been a perfectly understandable reason why this was put in there at the time
However, with modern Typescript this leads to issues, as it isn't able to infer the enum value. For example, the following code leads to issues:
Attached below is an illustration of what is going on:
When the typing is removed, the enum gets processed correctly and string/enum comparison works as expected.
Let me know if I'm missing something here. Please note that other typescript generators that I've checked don't have the type in place. (typescript-axios for example)