Skip to content

[BUG][JAVA] Missing Api interface while using apisToGenerate #14906 #15941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robp94
Copy link

@robp94 robp94 commented Jun 27, 2023

It is now possible to filter APIs with apisToGenerate based on their full path, like /v1/dogs. Prior to it, it was only possible to filter for the first part of the path, like v1.

This is solved with searching for filters which include / and handle them differently to filters without /. This should not break anything, since filters with / should have been useless before.

To test, use an API with multiple paths like in the linked issue and add one or multiple filters with the full path like /v1/dogs or /v1/dogs/{id}.

#14906

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Jul 13, 2023

cc @OpenAPITools/generator-core-team

@robp94
Copy link
Author

robp94 commented Nov 23, 2023

@wing328 I rebased on the current master. Could you approve the workflows? Although, who could review this pr?

@aleksandar-stefanovic-tamedia

Can someone push this one? apisToGenerate is useless at the moment.

@wing328
Copy link
Member

wing328 commented Apr 25, 2024

what about using the FILTER rule in openapi normalizer instead?

https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#openapi-normalizer

@aleksandar-stefanovic-tamedia

wing328

I'm confused. How can we filter out some routes by using normalizer? I'm getting json with full definition from external team and I need to exclude some API from list of generated clients for tests which I'm writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants