Skip to content

[Java][resttemplate] #13393 : Make queryParams known to UriComponents builder so it can properly encode them #14131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

aharonha
Copy link

@aharonha aharonha commented Nov 27, 2022

Make queryParams known to UriComponents builder so it can properly encode them

To close #13393

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@aharonha aharonha changed the title 13393: Make queryParams known to UriComponents builder so it can #13393: Make queryParams known to UriComponents builder so it can Nov 27, 2022
@aharonha aharonha changed the title #13393: Make queryParams known to UriComponents builder so it can [Java] #13393: Make queryParams known to UriComponents builder so it can Nov 27, 2022
@aharonha
Copy link
Author

Yet another solution like #13393

@aharonha
Copy link
Author

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)

@aharonha aharonha marked this pull request as ready for review November 27, 2022 14:55
@aharonha aharonha changed the title [Java] #13393: Make queryParams known to UriComponents builder so it can [Java][resttemplate] #13393 : Make queryParams known to UriComponents builder so it can Nov 27, 2022
@aharonha
Copy link
Author

@Willem1987 note that I have wrote this solution.
It has less changes than yours, so they might accept this fix.

@aharonha aharonha changed the title [Java][resttemplate] #13393 : Make queryParams known to UriComponents builder so it can [Java][resttemplate] #13393 : Make queryParams known to UriComponents builder so it can properly encode them Nov 28, 2022
@wing328 wing328 added this to the 6.3.0 milestone Nov 29, 2022
@wing328
Copy link
Member

wing328 commented Nov 30, 2022

@aharonha thanks for the PR. Can you please PM me via Slack when you've time?

ref: https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@aharonha
Copy link
Author

@aharonha thanks for the PR. Can you please PM me via Slack when you've time?

ref: https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328 I think I missed the "generate samples" part.
I didn't had the chance to go over this until now

@wing328
Copy link
Member

wing328 commented Dec 18, 2022

@aharonha when you've time, can you please PM me via Slack?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

@wing328
Copy link
Member

wing328 commented Dec 18, 2022

Closed via #14279

@wing328 wing328 closed this Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][Java][resttemplate] Query param values not encoded anymore
2 participants