Skip to content

The Instance is not a Set, it is a GrowableList, After checking Itera… #13536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cevheri
Copy link

@cevheri cevheri commented Sep 27, 2022

was marked as uniqueItems:true in API-DOC. The Instance is not a Set, it is a GrowableList, After checking Iterable, convert from GrowableList to Set
image

Hello there, I created a dart project using openapi-generator. In the api I used, the String Array inside a model was marked as uniqueItems=true. openapi-generator converted it to Set . In the generated code, the Serizalize/Deserialize operations in the fromJson() and toJson() methods in the model were incorrect. I fixed in the code I used first, and then I downloaded the openapi-generator's codes, forked it myself and made the correction there. I wanted to ask if anyone has had this problem before. I have now made the change/tests and will send a PR to Master Branch.

Generated Code:

  • Model Constructure:
    image
  • Field:
    image
    -toJson Method:
    image
  • fromJson Method:
    image

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @jaumard @josh-burton @amondnet @sbu-WBT @kuhnroyal @agilob @ahmednfwela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants