[Dart] Properly handle DateTime arrays using DateTimeHelper extension method #13432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the dart generator would not properly handle DateTime arrays. Instead, it would generate code that relies on a method that doesn't exist (DateTime.listFromJson). This update adds a DateTimeHelper extension to the api_helper.dart file and uses it anywhere there is a list of DateTimes.
ahmednfwela
suggested changes
Sep 15, 2022
| {{/description}} | ||
| {{^isEnum}} | ||
| {{#minimum}} | ||
| {{#description}} | ||
| /// | ||
| /// |
There was a problem hiding this comment.
are all the whitespace changes necessary?
There was a problem hiding this comment.
That was unintentional, I've updated the PR
jannikrh
reviewed
Jan 4, 2023
| @@ -150,7 +150,12 @@ class {{{classname}}} { | |||
| : null, | |||
| {{/items.isArray}} | |||
| {{^items.isArray}} | |||
| {{{name}}}: {{{complexType}}}.listFromJson(json[r'{{{baseName}}}']){{#required}}{{^isNullable}}!{{/isNullable}}{{/required}}{{^required}}{{#defaultValue}} ?? {{{.}}}{{/defaultValue}}{{/required}}, | |||
| {{#items.isDateTime}} | |||
There was a problem hiding this comment.
It would be nice to check here for date types via {{#items.isDate}} as well.
This was referenced May 13, 2025
|
Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses #11462.
Prior to this change, the dart generator would not properly handle DateTime arrays. Instead, it would generate code that relies on a method that doesn't exist (DateTime.listFromJson).
This update adds a DateTimeHelper extension to the api_helper.dart file and uses it anywhere there is a list of DateTimes.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.1.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)