Skip to content

Update Kotlin dependencies - use latest Kotlin and Ktor versions #12949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update Kotlin dependencies - use latest Kotlin and Ktor versions #12949

wants to merge 3 commits into from

Conversation

Marek00Malik
Copy link
Contributor

@Marek00Malik Marek00Malik commented Jul 20, 2022 •
edited
Loading

According to #11994, this change is updating Kotlin client dependencies, Kotlin version and what version of Ktor is used (2.0.3).

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the [@jimschubert, @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m ]

@Marek00Malik Marek00Malik force-pushed the feature/update-kotlin-dependecies-template branch from 0950de6 to c8b84c4 Compare July 20, 2022 09:33
@Marek00Malik Marek00Malik deleted the feature/update-kotlin-dependecies-template branch July 20, 2022 09:33
@Marek00Malik Marek00Malik restored the feature/update-kotlin-dependecies-template branch July 20, 2022 09:35
@Marek00Malik Marek00Malik deleted the feature/update-kotlin-dependecies-template branch July 20, 2022 09:36
@Marek00Malik Marek00Malik restored the feature/update-kotlin-dependecies-template branch July 20, 2022 09:37
@Marek00Malik Marek00Malik reopened this Jul 20, 2022
@Marek00Malik Marek00Malik marked this pull request as draft July 20, 2022 10:39
@Marek00Malik Marek00Malik marked this pull request as ready for review July 20, 2022 11:04
4brunu
4brunu reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@4brunu 4brunu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Marek00Malik, first of all, thanks for creating this PR.
Did you test if the dependency update didn't break anything?
Thanks

4brunu
4brunu reviewed Jul 20, 2022
View reviewed changes
samples/client/petstore/python-legacy/petstore_api/models/api_response.py
@@ -1,183 +0,0 @@
# coding: utf-8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marek00Malik could you please revert this file?

4brunu
4brunu reviewed Jul 20, 2022
View reviewed changes
samples/openapi3/client/petstore/python-legacy/docs/Client.md
@@ -1,11 +0,0 @@
# Client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marek00Malik could you please revert this file?

4brunu
4brunu reviewed Jul 20, 2022
View reviewed changes
samples/server/petstore/php-laravel/lib/app/RouteServiceProvider.php
@@ -1,39 +0,0 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Marek00Malik could you please revert this file?

@wing328
Copy link
Member

wing328 commented Jul 21, 2022

@Marek00Malik thanks for the PR but I would suggest you file a new file base on the latest master and target the master instead. PM me via Slack if you need any help on that. Thank. you.

@Marek00Malik
Copy link
Contributor Author

@Marek00Malik thanks for the PR but I would suggest you file a new file base on the latest master and target the master instead. PM me via Slack if you need any help on that. Thank. you.

Sure, on it. Thanks for the comments @4brunu I will push the fixes on the new PR

@Marek00Malik Marek00Malik deleted the feature/update-kotlin-dependecies-template branch July 21, 2022 09:11
@Marek00Malik
Copy link
Contributor Author

@wing328
New PR: #12966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4brunu 4brunu 4brunu left review comments

@jimschubert jimschubert Awaiting requested review from jimschubert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marek00Malik @wing328 @4brunu