Skip to content

Use Jdk4py #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2024
Merged

Use Jdk4py #18

merged 1 commit into from
Dec 3, 2024

Conversation

eggplants
Copy link
Member

@eggplants eggplants commented Dec 3, 2024 •
edited
Loading

Resolves #13

By using jdk4py, the command can be executed without installing the java runtime.

# with java
pipx install openapi-generator-cli
# python>=3.10, without java
pipx install openapi-generator-cli[jdk4py]

wing328
wing328 reviewed Dec 3, 2024
View reviewed changes
@eggplants eggplants marked this pull request as ready for review December 3, 2024 14:36
@eggplants eggplants requested a review from wing328 December 3, 2024 14:37
wing328
wing328 approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. let's give it a try

@eggplants eggplants merged commit 9b90ea0 into OpenAPITools:master Dec 3, 2024
7 checks passed
@eggplants eggplants deleted the jdk4py branch December 3, 2024 17:16
@eggplants eggplants mentioned this pull request Dec 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an (extra? optional?) dependency on jdk4py
2 participants
@eggplants @wing328