Web SDK Refactor: Update Logout #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sherwinski
reviewed
May 22, 2025
Comment on lines
+75
to
+83
| // replace models | ||
| const newIdentityModel = new IdentityModel(); | ||
| OneSignal.coreDirector.identityModelStore.replace(newIdentityModel); | ||
|
|
||
| // add the push subscription model back to the repo since we need at least 1 sub to create a new user | ||
| OneSignal.coreDirector.addSubscriptionModel(pushSubModel); | ||
| const newPropertiesModel = new PropertiesModel(); | ||
| OneSignal.coreDirector.propertiesModelStore.replace(newPropertiesModel); | ||
|
|
||
| // Initialize as non-local, make a request to OneSignal to create a new anonymous user | ||
| await UserDirector.initializeUser(); | ||
| // create a new anonymous user | ||
| UserDirector.initializeUser(); |
There was a problem hiding this comment.
updates logout method to reset model values for identityModel and propertyModel then calls initializeUser
What's the purpose of this change? Is it more aligned with the android SDK's logic or is it a cleaner approach?
There was a problem hiding this comment.
More aligned to Android SDK approach. I think alternatively we could just erase the external id from the models.
sherwinski
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Continuation of the Web SDK Refactor project.
Details
Systems Affected
Validation
Tests
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Checklist
Related Tickets
This change is