move the iso8601 SimpleDateFormat to its own class

Author: emawby

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessage.java

@@ -96,7 +96,7 @@ private Date parseEndTimeJson(JSONObject json) {
             return null;
         }
 
-        SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", Locale.US);
+        SimpleDateFormat format = OneSignalSimpleDateFormat.iso8601Format();
         try {
             Date date = format.parse(endTimeString);
             return date;
@@ -179,7 +179,7 @@ JSONObject toJSONObject() {
             json.put(IAM_TRIGGERS, orConditions);
 
             if (this.endTime != null) {
-                SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", Locale.US);
+                SimpleDateFormat format = OneSignalSimpleDateFormat.iso8601Format();
                 String endTimeString = format.format(this.endTime);
                 json.put(END_TIME, endTimeString);
             }

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignalSimpleDateFormat.java

@@ -0,0 +1,36 @@
+/**
+ * Modified MIT License
+ *
+ * Copyright 2020 OneSignal
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * 1. The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * 2. All copies of substantial portions of the Software may only be used in connection
+ * with services provided by OneSignal.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ * THE SOFTWARE.
+ */
+package com.onesignal;
+
+import java.text.SimpleDateFormat;
+import java.util.Locale;
+
+class OneSignalSimpleDateFormat {
+    static SimpleDateFormat iso8601Format() {
+        return new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'", Locale.US);
+    }
+}