Skip to content

Commit f4d8763

Browse files
committed
Call callback under disable
* If outcomes are disable, callback should be called
1 parent 5b082ed commit f4d8763

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSOutcomeEventsController.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,13 +204,17 @@ private void sendAndCreateOutcomeEvent(@NonNull final String name,
204204
break;
205205
case DISABLED:
206206
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "Outcomes disabled for channel: " + influence.getInfluenceChannel());
207+
if (callback != null)
208+
callback.onSuccess(null);
207209
return; // finish method
208210
}
209211
}
210212

211213
if (directSourceBody == null && indirectSourceBody == null && !unattributed) {
212214
// Disabled for all channels
213215
OneSignal.Log(OneSignal.LOG_LEVEL.VERBOSE, "Outcomes disabled for all channels");
216+
if (callback != null)
217+
callback.onSuccess(null);
214218
return;
215219
}
216220

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3215,6 +3215,7 @@ private static boolean isValidOutcomeEntry(String name) {
32153215
* 1. OutcomeEventParams cached already for re-attempt in future
32163216
* 2. Unique OutcomeEventParams already sent for ATTRIBUTED session and notification(s)
32173217
* 3. Unique OutcomeEventParams already sent for UNATTRIBUTED session during session
3218+
* 4. Outcomes disabled
32183219
*/
32193220
public interface OutcomeCallback {
32203221
void onSuccess(@Nullable OutcomeEvent outcomeEvent);

0 commit comments

Comments
 (0)