Skip to content

Commit debcbd6

Browse files
committed
Call willDisplay, didDisplay, didDismiss IAM methods
Utilizing existing WebViewManager callbacks
1 parent 20a1ccb commit debcbd6

File tree

1 file changed

+17
-5
lines changed

1 file changed

+17
-5
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageController.java

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,6 +284,9 @@ public void run() {
284284
}
285285

286286
void onMessageWasShown(@NonNull final OSInAppMessageInternal message) {
287+
288+
onMessageDidDisplay(message);
289+
287290
if (message.isPreview)
288291
return;
289292

@@ -344,39 +347,44 @@ void onMessageActionOccurredOnPreview(@NonNull final OSInAppMessageInternal mess
344347
logInAppMessagePreviewActions(action);
345348
}
346349

347-
/* IAM Lifecycle */
350+
/**
351+
* IAM Lifecycle methods
352+
* The following methods call the public inAppMessageLifecycleHandler callbacks
353+
*/
348354
void onMessageWillDisplay(@NonNull final OSInAppMessageInternal message) {
349355
if (OneSignal.inAppMessageLifecycleHandler == null) {
350-
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageWillDisplay: inAppMessageLifecycleHandler is null");
356+
logger.verbose("OSInAppMessageController onMessageWillDisplay: inAppMessageLifecycleHandler is null");
351357
return;
352358
}
353359
OneSignal.inAppMessageLifecycleHandler.onWillDisplayInAppMessage(message);
354360
}
355361

356362
void onMessageDidDisplay(@NonNull final OSInAppMessageInternal message) {
357363
if (OneSignal.inAppMessageLifecycleHandler == null) {
358-
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageDidDisplay: inAppMessageLifecycleHandler is null");
364+
logger.verbose("OSInAppMessageController onMessageDidDisplay: inAppMessageLifecycleHandler is null");
359365
return;
360366
}
361367
OneSignal.inAppMessageLifecycleHandler.onDidDisplayInAppMessage(message);
362368
}
363369

364370
void onMessageWillDismiss(@NonNull final OSInAppMessageInternal message) {
365371
if (OneSignal.inAppMessageLifecycleHandler == null) {
366-
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageWillDismiss: inAppMessageLifecycleHandler is null");
372+
logger.verbose("OSInAppMessageController onMessageWillDismiss: inAppMessageLifecycleHandler is null");
367373
return;
368374
}
369375
OneSignal.inAppMessageLifecycleHandler.onWillDismissInAppMessage(message);
370376
}
371377

372378
void onMessageDidDismiss(@NonNull final OSInAppMessageInternal message) {
373379
if (OneSignal.inAppMessageLifecycleHandler == null) {
374-
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageDidDismiss: inAppMessageLifecycleHandler is null");
380+
logger.verbose("OSInAppMessageController onMessageDidDismiss: inAppMessageLifecycleHandler is null");
375381
return;
376382
}
377383
OneSignal.inAppMessageLifecycleHandler.onDidDismissInAppMessage(message);
378384
}
379385

386+
/* End IAM Lifecycle methods */
387+
380388
private void logInAppMessagePreviewActions(final OSInAppMessageAction action) {
381389
if (action.getTags() != null)
382390
logger.debug("Tags detected inside of the action click payload, ignoring because action came from IAM preview:: " + action.getTags().toString());
@@ -654,6 +662,9 @@ void messageWasDismissed(@NonNull OSInAppMessageInternal message) {
654662
}
655663

656664
void messageWasDismissed(@NonNull OSInAppMessageInternal message, boolean failed) {
665+
if (!failed)
666+
onMessageDidDismiss(message);
667+
657668
if (!message.isPreview) {
658669
dismissedMessages.add(message.messageId);
659670
// If failed we will retry on next session
@@ -791,6 +802,7 @@ public void onSuccess(String response) {
791802
return;
792803
}
793804
OneSignal.getSessionManager().onInAppMessageReceived(message.messageId);
805+
onMessageWillDisplay(message);
794806
WebViewManager.showHTMLString(message, taggedHTMLString(htmlStr));
795807
} catch (JSONException e) {
796808
e.printStackTrace();

0 commit comments

Comments
 (0)