Skip to content

Commit 20a1ccb

Browse files
committed
Fill out lifecycle method calls in OSInAppMessageController
1 parent cd5c165 commit 20a1ccb

File tree

2 files changed

+22
-1
lines changed

2 files changed

+22
-1
lines changed

OneSignalSDK/onesignal/src/main/java/com/onesignal/OSInAppMessageController.java

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -346,15 +346,35 @@ void onMessageActionOccurredOnPreview(@NonNull final OSInAppMessageInternal mess
346346

347347
/* IAM Lifecycle */
348348
void onMessageWillDisplay(@NonNull final OSInAppMessageInternal message) {
349+
if (OneSignal.inAppMessageLifecycleHandler == null) {
350+
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageWillDisplay: inAppMessageLifecycleHandler is null");
351+
return;
352+
}
353+
OneSignal.inAppMessageLifecycleHandler.onWillDisplayInAppMessage(message);
349354
}
350355

351356
void onMessageDidDisplay(@NonNull final OSInAppMessageInternal message) {
357+
if (OneSignal.inAppMessageLifecycleHandler == null) {
358+
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageDidDisplay: inAppMessageLifecycleHandler is null");
359+
return;
360+
}
361+
OneSignal.inAppMessageLifecycleHandler.onDidDisplayInAppMessage(message);
352362
}
353363

354364
void onMessageWillDismiss(@NonNull final OSInAppMessageInternal message) {
365+
if (OneSignal.inAppMessageLifecycleHandler == null) {
366+
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageWillDismiss: inAppMessageLifecycleHandler is null");
367+
return;
368+
}
369+
OneSignal.inAppMessageLifecycleHandler.onWillDismissInAppMessage(message);
355370
}
356371

357372
void onMessageDidDismiss(@NonNull final OSInAppMessageInternal message) {
373+
if (OneSignal.inAppMessageLifecycleHandler == null) {
374+
OneSignal.onesignalLog(OneSignal.LOG_LEVEL.VERBOSE, "OSInAppMessageController onMessageDidDismiss: inAppMessageLifecycleHandler is null");
375+
return;
376+
}
377+
OneSignal.inAppMessageLifecycleHandler.onDidDismissInAppMessage(message);
358378
}
359379

360380
private void logInAppMessagePreviewActions(final OSInAppMessageAction action) {

OneSignalSDK/onesignal/src/main/java/com/onesignal/OneSignal.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,7 @@ static Activity getCurrentActivity() {
376376
static OSNotificationWillShowInForegroundHandler notificationWillShowInForegroundHandler;
377377
static OSNotificationOpenedHandler notificationOpenedHandler;
378378
static OSInAppMessageClickHandler inAppMessageClickHandler;
379+
static OSIAMLifecycleHandler inAppMessageLifecycleHandler;
379380

380381
// Is the init() of OneSignal SDK finished yet
381382
private static boolean initDone;
@@ -741,7 +742,7 @@ public static void setNotificationWillShowInForegroundHandler(@Nullable OSNotifi
741742
}
742743

743744
public static void setIAMLifecycleHandler(@Nullable OSIAMLifecycleHandler handler) {
744-
745+
inAppMessageLifecycleHandler = handler;
745746
}
746747

747748
public static void setNotificationOpenedHandler(@Nullable OSNotificationOpenedHandler callback) {

0 commit comments

Comments
 (0)