Skip to content

Commit b4b3c03

Browse files
jkasten2jinliu9508
authored andcommitted
Gradle config changes required for Gradle / AGP 8
* namespace is now always required * Some gradle.properties values were completely dropped in APG 8 * Publish release access changed to avoid build error, more changes are need to actually publish.
1 parent 1334fd2 commit b4b3c03

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

Examples/OneSignalDemo/app/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ plugins {
33
}
44

55
android {
6+
namespace 'com.onesignal.sdktest'
67
compileSdkVersion 34
78
defaultConfig {
89
minSdkVersion 21

Examples/OneSignalDemo/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
33
xmlns:tools="http://schemas.android.com/tools"
4-
xmlns:amazon="http://schemas.amazon.com/apk/res/android"
5-
package="com.onesignal.sdktest">
4+
xmlns:amazon="http://schemas.amazon.com/apk/res/android">
65

76
<uses-permission android:name="com.android.vending.BILLING" />
87

OneSignalSDK/gradle.properties

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@
2323
# Remove when creating an .aar build.
2424
#android.enableAapt2=false
2525

26-
android.databinding.incremental = false
27-
kapt.incremental.apt = false
28-
android.testConfig.useRelativePath = false
26+
org.gradle.jvmargs=-Xmx1536m
2927

3028
# Enables D8 for all modules.
3129
android.enableD8 = true

OneSignalSDK/onesignal/maven-push.gradle

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,9 @@ afterEvaluate {
6666

6767
publications {
6868
release(MavenPublication) {
69-
from components.release
69+
afterEvaluate {
70+
from components.findByName('release')
71+
}
7072

7173
pom {
7274
name = projectName

0 commit comments

Comments
 (0)