Skip to content

Commit 1334fd2

Browse files
jkasten2jinliu9508
authored andcommitted
Java compile errors from Gradle / AGP 8 upgrade
1 parent e8a0040 commit 1334fd2

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

Examples/OneSignalDemo/app/src/main/java/com/onesignal/sdktest/application/MainApplication.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121
import com.onesignal.notifications.IDisplayableNotification;
2222
import com.onesignal.notifications.INotificationLifecycleListener;
2323
import com.onesignal.notifications.INotificationWillDisplayEvent;
24-
import com.onesignal.sdktest.BuildConfig;
2524
import com.onesignal.sdktest.R;
2625
import com.onesignal.sdktest.constant.Tag;
2726
import com.onesignal.sdktest.constant.Text;
@@ -39,9 +38,8 @@ public class MainApplication extends MultiDexApplication {
3938
private static final int SLEEP_TIME_TO_MIMIC_ASYNC_OPERATION = 2000;
4039

4140
public MainApplication() {
42-
// run strict mode default in debug mode to surface any potential issues easier
43-
if(BuildConfig.DEBUG)
44-
StrictMode.enableDefaults();
41+
// run strict mode to surface any potential issues easier
42+
StrictMode.enableDefaults();
4543
}
4644

4745
@SuppressLint("NewApi")

OneSignalSDK/onesignal/notifications/src/main/java/com/onesignal/notifications/internal/display/impl/NotificationDisplayBuilder.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import android.net.Uri
1212
import android.os.Build
1313
import androidx.core.app.NotificationCompat
1414
import com.onesignal.common.AndroidUtils
15-
import com.onesignal.core.R
1615
import com.onesignal.core.internal.application.IApplicationService
1716
import com.onesignal.debug.internal.logging.Logging
1817
import com.onesignal.notifications.internal.bundle.impl.NotificationBundleProcessor
@@ -231,9 +230,9 @@ internal class NotificationDisplayBuilder(
231230
if (bitmap == null) return null
232231
try {
233232
val systemLargeIconHeight =
234-
contextResources!!.getDimension(R.dimen.notification_large_icon_height).toInt()
233+
contextResources!!.getDimension(android.R.dimen.notification_large_icon_height).toInt()
235234
val systemLargeIconWidth =
236-
contextResources!!.getDimension(R.dimen.notification_large_icon_width).toInt()
235+
contextResources!!.getDimension(android.R.dimen.notification_large_icon_width).toInt()
237236
val bitmapHeight = bitmap.height
238237
val bitmapWidth = bitmap.width
239238
if (bitmapWidth > systemLargeIconWidth || bitmapHeight > systemLargeIconHeight) {

0 commit comments

Comments
 (0)