add operation checks to all executors

To ensure operations are not silently skipped each executor now checks
if it can process all the operations. This is important since bugs can
go unnoticed for a while and without this it's hard to debug too.

Author: jkasten2

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/IdentityOperationExecutor.kt

@@ -26,6 +26,16 @@ internal class IdentityOperationExecutor(
     override suspend fun execute(operations: List<Operation>): ExecutionResponse {
         Logging.debug("IdentityOperationExecutor(operations: $operations)")
 
+        if (operations.any { it !is SetAliasOperation && it !is DeleteAliasOperation }) {
+            throw Exception("Unrecognized operation(s)! Attempted operations:\n$operations")
+        }
+
+        if (operations.any { it is SetAliasOperation } &&
+            operations.any { it is DeleteAliasOperation }
+        ) {
+            throw Exception("Can't process SetAliasOperation and DeleteAliasOperation at the same time.")
+        }
+
         // An alias group is an appId/onesignalId/aliasLabel combo, so we only care
         // about the last operation in the group, as that will be the effective end
         // state to this specific alias for this user.

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/LoginUserFromSubscriptionOperationExecutor.kt

@@ -27,6 +27,10 @@ internal class LoginUserFromSubscriptionOperationExecutor(
     override suspend fun execute(operations: List<Operation>): ExecutionResponse {
         Logging.debug("LoginUserFromSubscriptionOperationExecutor(operation: $operations)")
 
+        if (operations.size > 1) {
+            throw Exception("Only supports one operation! Attempted operations:\n$operations")
+        }
+
         val startingOp = operations.first()
 
         if (startingOp is LoginUserFromSubscriptionOperation) {

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/LoginUserOperationExecutor.kt

@@ -55,7 +55,7 @@ internal class LoginUserOperationExecutor(
         val startingOp = operations.first()
 
         if (startingOp is LoginUserOperation) {
-            return loginUser(startingOp, operations)
+            return loginUser(startingOp, operations.drop(1))
         }
 
         throw Exception("Unrecognized operation: $startingOp")
@@ -153,6 +153,7 @@ internal class LoginUserOperationExecutor(
                 is TransferSubscriptionOperation -> subscriptions = createSubscriptionsFromOperation(operation, subscriptions)
                 is UpdateSubscriptionOperation -> subscriptions = createSubscriptionsFromOperation(operation, subscriptions)
                 is DeleteSubscriptionOperation -> subscriptions = createSubscriptionsFromOperation(operation, subscriptions)
+                else -> throw Exception("Unrecognized operation: $operation")
             }
         }
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/RefreshUserOperationExecutor.kt

@@ -38,6 +38,10 @@ internal class RefreshUserOperationExecutor(
     override suspend fun execute(operations: List<Operation>): ExecutionResponse {
         Logging.log(LogLevel.DEBUG, "RefreshUserOperationExecutor(operation: $operations)")
 
+        if (operations.any { it !is RefreshUserOperation }) {
+            throw Exception("Unrecognized operation(s)! Attempted operations:\n$operations")
+        }
+
         val startingOp = operations.first()
         if (startingOp is RefreshUserOperation) {
             return getUser(startingOp)

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/SubscriptionOperationExecutor.kt

@@ -49,10 +49,17 @@ internal class SubscriptionOperationExecutor(
         return if (startingOp is CreateSubscriptionOperation) {
             createSubscription(startingOp, operations)
         } else if (operations.any { it is DeleteSubscriptionOperation }) {
-            deleteSubscription(operations.first { it is DeleteSubscriptionOperation } as DeleteSubscriptionOperation)
+            if (operations.size > 1) {
+                throw Exception("Only supports one operation! Attempted operations:\n$operations")
+            }
+            val deleteSubOps = operations.filterIsInstance<DeleteSubscriptionOperation>()
+            deleteSubscription(deleteSubOps.first())
         } else if (startingOp is UpdateSubscriptionOperation) {
             updateSubscription(startingOp, operations)
         } else if (startingOp is TransferSubscriptionOperation) {
+            if (operations.size > 1) {
+                throw Exception("TransferSubscriptionOperation only supports one operation! Attempted operations:\n$operations")
+            }
             transferSubscription(startingOp)
         } else {
             throw Exception("Unrecognized operation: $startingOp")

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/impl/executors/UpdateUserOperationExecutor.kt

@@ -114,6 +114,7 @@ internal class UpdateUserOperationExecutor(
 
                     deltasObject = PropertiesDeltasObject(deltasObject.sessionTime, deltasObject.sessionCount, amountSpent, purchasesArray)
                 }
+                else -> throw Exception("Unrecognized operation: $operation")
             }
         }