fix missing modify keys on some operations

All operations must have at least a create or modify key, this is
required so operations are not grouped together when they should not be.

This fixes a bug where calling addTag() back-to-back with login() would
cause the login to be dropped. This is because
SetTagOperation.modifyComparisonKey was "" which matched
LoginUserOperation.modifyComparisonKey as it was also "" and both these
operations we returned by OperationRepo.getGroupableOperations. Both
operations were given to UpdateUserOperationExecutor which it would skip
the LoginUserOperation silently.

This mistake originated from f1d204e
which wasn't in the 5.0.0-beta4 release, but was introduced in 5.0.0.
The intent of PR #1794 is still preserved in this commit, we just simply
fixed the bug noted above.

Author: jkasten2

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/DeleteTagOperation.kt

@@ -39,7 +39,7 @@ class DeleteTagOperation() : Operation(UpdateUserOperationExecutor.DELETE_TAG) {
         }
 
     override val createComparisonKey: String get() = ""
-    override val modifyComparisonKey: String get() = createComparisonKey
+    override val modifyComparisonKey: String get() = "$appId.User.$onesignalId"
     override val groupComparisonType: GroupComparisonType = GroupComparisonType.ALTER
     override val canStartExecute: Boolean get() = !IDManager.isLocalId(onesignalId)
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/SetPropertyOperation.kt

@@ -47,7 +47,7 @@ class SetPropertyOperation() : Operation(UpdateUserOperationExecutor.SET_PROPERT
         }
 
     override val createComparisonKey: String get() = ""
-    override val modifyComparisonKey: String get() = createComparisonKey
+    override val modifyComparisonKey: String get() = "$appId.User.$onesignalId"
     override val groupComparisonType: GroupComparisonType = GroupComparisonType.ALTER
     override val canStartExecute: Boolean get() = !IDManager.isLocalId(onesignalId)
 

OneSignalSDK/onesignal/core/src/main/java/com/onesignal/user/internal/operations/SetTagOperation.kt

@@ -48,7 +48,7 @@ class SetTagOperation() : Operation(UpdateUserOperationExecutor.SET_TAG) {
         }
 
     override val createComparisonKey: String get() = ""
-    override val modifyComparisonKey: String get() = createComparisonKey
+    override val modifyComparisonKey: String get() = "$appId.User.$onesignalId"
     override val groupComparisonType: GroupComparisonType = GroupComparisonType.ALTER
     override val canStartExecute: Boolean get() = !IDManager.isLocalId(onesignalId)